https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/66683
As reported in #66612, we aren't correctly treating the placeholder expression
type correctly, so we ended up trying to get a reference version of it, and
this resulted in an assertion, since the placeholder
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
As reported in #66612, we aren't correctly treating the placeholder
expression type correctly, so we ended up trying to get a reference version of
it, and this resulted in an assertion, since the placeholder type cannot have a
reference a
@@ -9063,7 +9063,8 @@ Sema::BuildExprRequirement(
concepts::ExprRequirement::ReturnTypeRequirement ReturnTypeRequirement) {
auto Status = concepts::ExprRequirement::SS_Satisfied;
ConceptSpecializationExpr *SubstitutedConstraintExpr = nullptr;
- if (E->isInstantiationDe
@@ -9063,7 +9063,8 @@ Sema::BuildExprRequirement(
concepts::ExprRequirement::ReturnTypeRequirement ReturnTypeRequirement) {
auto Status = concepts::ExprRequirement::SS_Satisfied;
ConceptSpecializationExpr *SubstitutedConstraintExpr = nullptr;
- if (E->isInstantiationDe
cor3ntin wrote:
Do we need a release note for this (probably!)?
https://github.com/llvm/llvm-project/pull/66683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
> Do we need a release note for this (probably!)?
Bah, yes we do...
https://github.com/llvm/llvm-project/pull/66683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -9063,7 +9063,8 @@ Sema::BuildExprRequirement(
concepts::ExprRequirement::ReturnTypeRequirement ReturnTypeRequirement) {
auto Status = concepts::ExprRequirement::SS_Satisfied;
ConceptSpecializationExpr *SubstitutedConstraintExpr = nullptr;
- if (E->isInstantiationDe
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/66683
>From 5b4748e3ae06a5b90ecb2c84b7df989a94733175 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 18 Sep 2023 11:38:12 -0700
Subject: [PATCH 1/2] In ExprRequirement building, treat OverloadExpr as
dependent
https://github.com/cor3ntin approved this pull request.
LGTM (but now you have conflicts in the release notes!)
https://github.com/llvm/llvm-project/pull/66683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
