[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

@@ -652,14 +647,14 @@ bool Parser::ParseTopLevelDecl(DeclGroupPtrTy &Result, // Recognize context-sensitive C++20 'export module' and 'export import' // declarations. case tok::identifier: { - IdentifierInfo *II = NextToken().getIdentifierInfo(); - if ((II

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

@@ -4558,6 +4574,12 @@ bool Lexer::LexDependencyDirectiveToken(Token &Result) { Result.setRawIdentifierData(TokPtr); if (!isLexingRawMode()) { const IdentifierInfo *II = PP->LookUpIdentifierInfo(Result); + if (Result.isModuleContextualKeyword()) { +//

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

https://github.com/shafik commented: Minor comments, I agree with @cor3ntin that you should split this into two PRs. It will be much better to review in smaller form. https://github.com/llvm/llvm-project/pull/102135 ___ cfe-commits mailing list cfe-co

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/102135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

yronglin wrote: > This PR is starting to get quite large. Can [Modules Dependency > Discover](https://github.com/llvm/llvm-project/pull/102135/commits/581160a121fca5796bff2392d9228207d37e6f16) > be split in a separate PR? > > Edit: ie, maybe we can implement P1857R3 first ? This sounds good t

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

cor3ntin wrote: This PR is starting to get quite large. Can [Modules Dependency Discover](https://github.com/llvm/llvm-project/pull/102135/commits/581160a121fca5796bff2392d9228207d37e6f16) be split in a separate PR? https://github.com/llvm/llvm-project/pull/102135 _

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/102135 >From efa62c3c8572f9c94cf0e2e9ac5a1fb11746ddc7 Mon Sep 17 00:00:00 2001 From: yronglin Date: Tue, 23 Jul 2024 19:46:49 +0800 Subject: [PATCH 1/6] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20De?= =?UTF-8

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (yronglin) Changes This PR reapply [[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros](https://github.com/llvm/llvm-project/pull/90574), and partially implement [P1857R3 Modules Dependency Discovery](https://www.open

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

https://github.com/yronglin ready_for_review https://github.com/llvm/llvm-project/pull/102135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

@@ -136,6 +136,8 @@ class Lexer : public PreprocessorLexer { bool IsAtPhysicalStartOfLine; + bool IsCurrentLexingTokAtPhysicalStartOfLine; yronglin wrote: Thanks for your review! This change introduced by https://github.com/llvm/llvm-project/pull/102135/

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

yronglin wrote: > is this ready for review? Yeah, it's ready now. https://github.com/llvm/llvm-project/pull/102135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/102135 >From efa62c3c8572f9c94cf0e2e9ac5a1fb11746ddc7 Mon Sep 17 00:00:00 2001 From: yronglin Date: Tue, 23 Jul 2024 19:46:49 +0800 Subject: [PATCH 1/5] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20De?= =?UTF-8

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/102135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f2f410ca1317e7d2da89be0729a63a26ca83e7d7 581160a121fca5796bff2392d9228207d37e6f16 --e

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/102135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" (PR #102135)

https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/102135 This PR reapply [[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros](https://github.com/llvm/llvm-project/pull/90574), and partially implement [P1857R3 Modules Dependency Discovery](https://www