[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2024-01-13 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/70217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2024-01-13 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Will wait for the EWG to give final guidance. https://github.com/llvm/llvm-project/pull/70217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-27 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Thanks @zygoloid for filing the core issue https://cplusplus.github.io/CWG/issues/2804.html Would it make sense to go forward with this change and fix rewrite targets for friend operators (as a clang extension)? https://github.com/llvm/llvm-project/pull/70217 __

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-26 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/70217 >From 26b9570fadf428e2f55efe0f2d9433cf18305239 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 25 Oct 2023 16:55:15 +0200 Subject: [PATCH 1/4] friend operator!= --- clang/lib/Sema/SemaOverload.cpp

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cc2fbc648d7babbfa612f4f5eda3160212ef6ca7 26b9570fadf428e2f55efe0f2d9433cf18305239 --

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/70217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/70217 >From 26b9570fadf428e2f55efe0f2d9433cf18305239 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 25 Oct 2023 16:55:15 +0200 Subject: [PATCH 1/3] friend operator!= --- clang/lib/Sema/SemaOverload.cpp

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes The namespace lookup should give a matching friend operator!= as friend functions belong to the namespace scope (as opposed to the lexical class scope). Thus to resolve ambiguity of operator== with itself, d

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/70217 >From 26b9570fadf428e2f55efe0f2d9433cf18305239 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 25 Oct 2023 16:55:15 +0200 Subject: [PATCH 1/2] friend operator!= --- clang/lib/Sema/SemaOverload.cpp

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/70217 The namespace lookup should give a matching friend operator!= as friend functions belong to the namespace scope (as opposed to the lexical class scope). Thus to resolve ambiguity of operator== with itself, defining