cjdb wrote:
Thanks @amykhuang!
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang closed
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/67199
>From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 22 Sep 2023 14:40:14 -0700
Subject: [PATCH 1/4] Recommit "Implement [[msvc::no_unique_address]] (#65675)"
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amykhuang wrote:
Added a section for target specific spellings in
`GenerateHasAttrSpellingStringSwitch`, and a check for "existsInTarget" in
`ParseCXX11AttributeArgs`, and looks like all tests are passing now.
https://github.com/llvm/llvm-project/pull/67199
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/67199
>From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 22 Sep 2023 14:40:14 -0700
Subject: [PATCH 1/3] Recommit "Implement [[msvc::no_unique_address]] (#65675)"
amykhuang wrote:
hmm this passes most of the checks in SemaCXX/cxx2a-no-unique-address.cpp, but
fails "attribute 'no_unique_address' cannot have an argument list". Also fails
Preprocessor/has_attribute.cpp because both attributes are recognized on
itanium and windows targets.
zygoloid wrote:
(Please remember to update the commit message to describe the tablegen change
when merging.)
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/zygoloid resolved
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zygoloid approved this pull request.
Looks awesome, thanks :)
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/67199
>From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Fri, 22 Sep 2023 14:40:14 -0700
Subject: [PATCH 1/2] Recommit "Implement [[msvc::no_unique_address]] (#65675)"
@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr,
TargetSpecificAttr {
let Documentation = [ArmMveStrictPolymorphismDocs];
}
-def NoUniqueAddress : InheritableAttr, TargetSpecificAttr
{
- let Spellings = [CXX11<"", "no_unique_address", 201803>];
+def
@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr,
TargetSpecificAttr {
let Documentation = [ArmMveStrictPolymorphismDocs];
}
-def NoUniqueAddress : InheritableAttr, TargetSpecificAttr
{
- let Spellings = [CXX11<"", "no_unique_address", 201803>];
+def
@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr,
TargetSpecificAttr {
let Documentation = [ArmMveStrictPolymorphismDocs];
}
-def NoUniqueAddress : InheritableAttr, TargetSpecificAttr
{
- let Spellings = [CXX11<"", "no_unique_address", 201803>];
+def
amykhuang wrote:
Previous commit attempt caused sphinx errors. Also, because we now have two
attributes for the itanium and MSVC versions, there are two separate sections
in the documentation, which I didn't realize before.
https://github.com/llvm/llvm-project/pull/67199
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Change the attribute docs so that there is a separate one for the MSVC
attribute.
This reverts commit 71f9e7695b87298f9855d8890f0e6a3b89381eb5.
---
Patch is 25.37 KiB, truncated to 20.00 KiB below, full version:
https://github.com/amykhuang created
https://github.com/llvm/llvm-project/pull/67199
Change the attribute docs so that there is a separate one for the MSVC
attribute.
This reverts commit 71f9e7695b87298f9855d8890f0e6a3b89381eb5.
>From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17
18 matches
Mail list logo
