[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

antangelo wrote: Thank you for the reproducers! I have posted a candidate reland that addresses both of these issues here: https://github.com/llvm/llvm-project/pull/73087 https://github.com/llvm/llvm-project/pull/69676 ___ cfe-commits mailing list

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

kadircet wrote: thanks for the revert! I also encountered certain crashes bisecting back to this patch, with a similar reproducer: ``` template struct Module { template struct Baz { template explicit Baz(X); }; Baz(int) -> Baz; }; struct Bar {}; void foo() { Module::Baz

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

aeubanks wrote: thanks! I appreciate the quick response https://github.com/llvm/llvm-project/pull/69676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

antangelo wrote: Apologies for the delay, I haven't been able to look into this until now. The patch has been reverted in https://github.com/llvm/llvm-project/commit/801c78d5b474c2319aa8ead44db7ba8cacac4714 https://github.com/llvm/llvm-project/pull/69676

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

aeubanks wrote: and if not, could we revert while investigating? https://github.com/llvm/llvm-project/pull/69676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

aeubanks wrote: this breaks ``` $ cat /tmp/a2.ii template struct enable_if; template struct A { template struct C { C(B...); template = 0> C(A); }; template C(B...) -> C; }; int New; struct S : A { void f() { C{New}; } }; $ clang -fsyntax-only -std=c++20

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

https://github.com/antangelo closed https://github.com/llvm/llvm-project/pull/69676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/69676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes Reland of dd0fba11690f9fef304d5f48cde646e5eca8d3c0 When a nested template is instantiated, the template pattern of the inner class is not copied into the outer class ClassTemplateSpecializationDecl. The

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/69676 Reland of dd0fba11690f9fef304d5f48cde646e5eca8d3c0 When a nested template is instantiated, the template pattern of the inner class is not copied into the outer class ClassTemplateSpecializationDecl. The