ChuanqiXu9 wrote:
I sent the new PR in https://github.com/llvm/llvm-project/pull/84881. See the
comments there for details.
https://github.com/llvm/llvm-project/pull/82160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
ChuanqiXu9 wrote:
> @ChuanqiXu9 since you suggested this test approach
It looks like that I failed to understand VE is under X86 also...
> do you know whether this is the expected behavior of -sysroot ?
I am not sure. This is surprising to me too.
> The point is to build libraries and test
mordante wrote:
> The point is to build libraries and test clang at once. The `TC.getFilePaths`
> is constructed from following items in `ToolChain::ToolChain`
>
> 1. `BUILD/bin/../lib/x86_64-unknown-linux-gnu`
>
> 2. `%t/Inputs/usr/lib/x86_64-linux-gnu`
>
> 3. `%t/Inputs/usr/lib`
mordante wrote:
Thanks for the revert and additional information. I was expecting that the test
should not be affected by files outside of the `%t/Inputs` directory. I will
test this locally, it might take a few days before I have time.
https://github.com/llvm/llvm-project/pull/82160
_
kaz7 wrote:
The point is to build libraries and test clang. The `TC.getFilePaths` is
constructed from following items in `ToolChain::ToolChain`
1. `BUILD/bin/../lib/x86_64-unknown-linux-gnu`
2. `%t/Inputs/usr/lib/x86_64-linux-gnu`
3. `%t/Inputs/usr/lib`
Yes. It contains 1st item at run time
kaz7 wrote:
Reverted. It is possible to reproduce erros by following commands.
```
$ mkdir build
$ cd build
$ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release ../llvm-project/llvm
-DLLVM_ENABLE_PROJECTS=clang -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind"
$ ninja
$ ninja check-clang
kaz7 wrote:
Unfortunately, this is breaking VE buildbot again. I'll check the source of
your problem, but can you revert your patch once?
https://lab.llvm.org/buildbot/#/builders/91/builds/23291
https://github.com/llvm/llvm-project/pull/82160
___
cf
mordante wrote:
> @mordante if we want this for 18, we need to land and backport it in this
> week.
Thanks for the reminder, it got a bit under my radar. I'll ask a backport
tomorrow unless a CI starts to complain again.
https://github.com/llvm/llvm-project/pull/82160
https://github.com/mordante closed
https://github.com/llvm/llvm-project/pull/82160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/82160
>From cb3f20463548110617fd555ac11ee58d5b8b7ad5 Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Sun, 18 Feb 2024 12:57:33 +0100
Subject: [PATCH 1/2] Reland "[clang][modules] Print library module manifest
path
ChuanqiXu9 wrote:
@mordante if we want this for 18, we need to land and backport it in this week.
https://github.com/llvm/llvm-project/pull/82160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
@@ -0,0 +1,38 @@
+// Test that -print-library-module-manifest-path finds the correct file.
+
+// REQUIRES: x86-registered-target
ChuanqiXu9 wrote:
```suggestion
// FIXME:
// REQUIRES: x86-registered-target
```
I feel better with a FIXME to remind us to remo
https://github.com/ChuanqiXu9 approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/82160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/82160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mark de Wever (mordante)
Changes
This implements a way for the compiler to find the modules.json associated with
the C++23 Standard library modules.
This is based on a discussion in SG15. At the moment no Standard library
installs this m
https://github.com/mordante created
https://github.com/llvm/llvm-project/pull/82160
This implements a way for the compiler to find the modules.json associated with
the C++23 Standard library modules.
This is based on a discussion in SG15. At the moment no Standard library
installs this manife
16 matches
Mail list logo