mordante wrote:
> Can we also have a fallback check for stdlibs that don't have a `.so` version
> (such as embedded)? Something as simple as:
>
> ```c++
> std::string lib = GetFilePath("libc++.so", TC);
> if (lib.empty())
> lib = GetFilePath("libc++.a", TC);
> ```
Excellent
stellar-aria wrote:
Can we also have a fallback check for stdlibs that don't have a `.so` version
(such as embedded)? Something as simple as:
```c++
std::string lib = GetFilePath("libc++.so", TC);
if (lib.empty())
lib = GetFilePath("libc++.a", TC);
```
mordante wrote:
Build system don't use this yet (since it wasn't available). I know CMake is
working on implementing modules using libc++. Looking at the stage of the
release I feel less comfortable to propose new features. So I think the feature
should not be back ported.
I'm happy to pick
ChuanqiXu9 wrote:
> > > > > The file we're looking for is `modules.json`; Renaming it
> > > > > `libc++.modules.json` like `.so` / `.a` file might be a better idea
> > > > > which could avoid name clashes when installed in `/usr/lib`.
> > > >
> > > >
> > > > but i didn't rename it, it was
mordante wrote:
> > > > The file we're looking for is `modules.json`; Renaming it
> > > > `libc++.modules.json` like `.so` / `.a` file might be a better idea
> > > > which could avoid name clashes when installed in `/usr/lib`.
> > >
> > >
> > > but i didn't rename it, it was with the libc++
ChuanqiXu9 wrote:
> > > The file we're looking for is `modules.json`; Renaming it
> > > `libc++.modules.json` like `.so` / `.a` file might be a better idea which
> > > could avoid name clashes when installed in `/usr/lib`.
> >
> >
> > but i didn't rename it, it was with the libc++ prefix
mordante wrote:
> > The file we're looking for is `modules.json`; Renaming it
> > `libc++.modules.json` like `.so` / `.a` file might be a better idea which
> > could avoid name clashes when installed in `/usr/lib`.
>
> but i didn't rename it, it was with the libc++ prefix directly :/
Good
llvmbot wrote:
/pull-request llvm/llvm-project#85637
https://github.com/llvm/llvm-project/pull/84881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Arthapz wrote:
> The file we're looking for is `modules.json`; Renaming it
> `libc++.modules.json` like `.so` / `.a` file might be a better idea which
> could avoid name clashes when installed in `/usr/lib`.
but i didn't rename it, it was installed like this :/
ChuanqiXu9 wrote:
/cherry-pick 0e1e1fc8f0e
https://github.com/llvm/llvm-project/pull/84881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 milestoned
https://github.com/llvm/llvm-project/pull/84881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
> The file we're looking for is `modules.json`; Renaming it
> `libc++.modules.json` like `.so` / `.a` file might be a better idea which
> could avoid name clashes when installed in `/usr/lib`.
BTW, how do you feel about the paragraph. I thought it as a defect in some
level.
mordante wrote:
The file we're looking for is `modules.json`; Renaming it `libc++.modules.json`
like `.so` / `.a` file might be a better idea which could avoid name clashes
when installed in `/usr/lib`.
https://github.com/llvm/llvm-project/pull/84881
Arthapz wrote:
How do we use this ?
i tried
```
> /opt/llvm-git/usr/bin/clang -std=c++23 -stdlib=libc++
> -print-library-module-manifest-path
```
and
```
> /opt/llvm-git/usr/bin/clang -std=c++23 -stdlib=libc++
> -print-library-module-manifest-path -resource-dir=/opt/llvm-git/usr/lib
```
ChuanqiXu9 wrote:
I'll backport this tomorrow if no revert request shows up.
https://github.com/llvm/llvm-project/pull/84881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/84881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mordante approved this pull request.
Thanks for picking it up @ChuanqiXu9 and thanks for testing @kaz7.
https://github.com/llvm/llvm-project/pull/84881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/kaz7 approved this pull request.
Thank you for updating test scripts. It works fine in the situation I
explained before. It works fine under VE buildbot configuration too.
https://github.com/llvm/llvm-project/pull/84881
___
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Chuanqi Xu (ChuanqiXu9)
Changes
Following of https://github.com/llvm/llvm-project/pull/82160
The reason why the above PR fails is that the `--sysroot` has lower priority
than the libc++ built from the same source. On the one
https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/84881
Following of https://github.com/llvm/llvm-project/pull/82160
The reason why the above PR fails is that the `--sysroot` has lower priority
than the libc++ built from the same source. On the one hand, it
20 matches
Mail list logo
