https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/97342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/svenvh approved this pull request.
https://github.com/llvm/llvm-project/pull/97342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/16] [NFC] Add assertion to ensure that FiniteMathOnly
to
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/15] [NFC] Add assertion to ensure that FiniteMathOnly
to
@@ -1,6 +1,6 @@
// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s -check-prefix=NORMAL
// RUN: %clang_cc1 %s -emit-llvm -cl-fast-relaxed-math -o - | FileCheck %s
-check-prefix=FAST
-// RUN: %clang_cc1 %s -emit-llvm -cl-finite-math-only -o - | FileCheck %s
-check-prefix=FINI
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/14] [NFC] Add assertion to ensure that FiniteMathOnly
to
@@ -1,6 +1,6 @@
// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s -check-prefix=NORMAL
// RUN: %clang_cc1 %s -emit-llvm -cl-fast-relaxed-math -o - | FileCheck %s
-check-prefix=FAST
-// RUN: %clang_cc1 %s -emit-llvm -cl-finite-math-only -o - | FileCheck %s
-check-prefix=FINI
@@ -816,6 +816,11 @@ class FPOptions {
setAllowFPReassociate(LO.AllowFPReassoc);
setNoHonorNaNs(LO.NoHonorNaNs);
setNoHonorInfs(LO.NoHonorInfs);
+// Ensure that if FiniteMathOnly is enabled, NoHonorNaNs and NoHonorInfs
are
+// also enabled. This is because
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/97342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -816,6 +816,11 @@ class FPOptions {
setAllowFPReassociate(LO.AllowFPReassoc);
setNoHonorNaNs(LO.NoHonorNaNs);
setNoHonorInfs(LO.NoHonorInfs);
+// Ensure that if FiniteMathOnly is enabled, NoHonorNaNs and NoHonorInfs
are
+// also enabled. This is because
https://github.com/AaronBallman approved this pull request.
Changes LGTM, I've added @MaskRay and @jansvoboda11 in case they can help
answer the OpenCL questions, as it seems @AnastasiaStulova may be unavailable
at the moment.
If we don't hear back from anyone in the next two days, I think it'
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/13] [NFC] Add assertion to ensure that FiniteMathOnly
to
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/14] [NFC] Add assertion to ensure that FiniteMathOnly
to
AaronBallman wrote:
Ping @AnastasiaStulova for OpenCL feedback (this PR impacts an OpenCL command
line option).
https://github.com/llvm/llvm-project/pull/97342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/13] [NFC] Add assertion to ensure that FiniteMathOnly
to
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/12] [NFC] Add assertion to ensure that FiniteMathOnly
to
@@ -174,9 +174,10 @@ static void addVisualCDefines(const LangOptions &Opts,
MacroBuilder &Builder) {
// transformation unless the transformation is guaranteed to produce a
bitwise
// identical result."
const bool any_imprecise_flags =
- Opts.FastMath || Opts.Finite
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/11] [NFC] Add assertion to ensure that FiniteMathOnly
to
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 01/10] [NFC] Add assertion to ensure that FiniteMathOnly
to
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 1/9] [NFC] Add assertion to ensure that FiniteMathOnly toggl
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
https://github.com/AaronBallman deleted
https://github.com/llvm/llvm-project/pull/97342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 1/8] [NFC] Add assertion to ensure that FiniteMathOnly toggl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 1/7] [NFC] Add assertion to ensure that FiniteMathOnly toggl
@@ -34,8 +34,8 @@ void LangOptions::resetNonModularOptions() {
// invocations that cannot be round-tripped to arguments.
// FIXME: we should derive this automatically from ImpliedBy in tablegen.
AllowFPReassoc = UnsafeFPMath;
- NoHonorNaNs = FiniteMathOnly;
- NoHonorInf
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 1/6] [NFC] Add assertion to ensure that FiniteMathOnly toggl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/97342
>From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 1 Jul 2024 12:56:07 -0700
Subject: [PATCH 1/5] [NFC] Add assertion to ensure that FiniteMathOnly toggl
@@ -3295,7 +3295,17 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues, NanValues = true;
mdtoguchi wrote:
`InfValues` isn't initi
@@ -3295,7 +3295,17 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues, NanValues = true;
+ auto processArg = [&](const auto *Arg) {
+if (Strin
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/97342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
38 matches
Mail list logo
