[clang] Resolve FIXME: Look at E, not M. (PR #85541)

https://github.com/AtariDreams created https://github.com/llvm/llvm-project/pull/85541 None >From cc61f38116b2b9143dbc96d45a35efc065d258f5 Mon Sep 17 00:00:00 2001 From: Rose Date: Sat, 16 Mar 2024 12:07:21 -0400 Subject: [PATCH] Resolve FIXME: Look at E, not M. --- clang/lib/CodeGen/CGExpr.

[clang] Resolve FIXME: Look at E, not M. (PR #85541)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: AtariDreams (AtariDreams) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/85541.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGExpr.cpp (+1-3) ``diff diff --git a/

[clang] Resolve FIXME: Look at E, not M. (PR #85541)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85541 >From e4af1febaa05e2749947b7cd406d65df5a1a7539 Mon Sep 17 00:00:00 2001 From: Rose Date: Sat, 16 Mar 2024 12:07:21 -0400 Subject: [PATCH] Resolve FIXME: Look at E, not M. --- clang/lib/CodeGen/CGExpr.cpp |

[clang] Resolve FIXME: Look at E, not M. (PR #85541)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c51095f51b770f0663b65dd8a651601fca15701e e4af1febaa05e2749947b7cd406d65df5a1a7539 --

[clang] Resolve FIXME: Look at E, not M. (PR #85541)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85541 >From 369cd6fcebc22f926f7b002f64a44f866283a0c1 Mon Sep 17 00:00:00 2001 From: Rose Date: Sat, 16 Mar 2024 12:07:21 -0400 Subject: [PATCH] Resolve FIXME: Look at E, not M. --- clang/lib/CodeGen/CGExpr.cpp |

[clang] Resolve FIXME: Look at E, not M. (PR #85541)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85541 >From 214a2528f8f1383c997fc7906912bcb2993cf9d6 Mon Sep 17 00:00:00 2001 From: Rose Date: Sat, 16 Mar 2024 12:07:21 -0400 Subject: [PATCH] Resolve FIXME: Look at E, not M. --- clang/lib/CodeGen/CGExpr.cpp |

[clang] Resolve FIXME: Look at E, not M (PR #85541)

https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/85541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Resolve FIXME: Look at E, not M (PR #85541)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85541 >From c0f8be4fcfb725d53841d4b17a68685e2a79 Mon Sep 17 00:00:00 2001 From: Rose Date: Sat, 16 Mar 2024 12:07:21 -0400 Subject: [PATCH] Resolve FIXME: Look at E, not M --- clang/lib/CodeGen/CGExpr.cpp | 9

[clang] Resolve FIXME: Look at E, not M (PR #85541)

efriedma-quic wrote: I assume the FIXME is referring to some deeper change here? If it were that easy, the FIXME wouldn't be there in the first place. CC @zygoloid @rjmccall https://github.com/llvm/llvm-project/pull/85541 ___ cfe-commits mailing list

[clang] Resolve FIXME: Look at E, not M (PR #85541)

rjmccall wrote: Well, sometimes we do leave FIXMEs that end up being suprisingly easy to fix. But what FIXME are we talking about here? The patch doesn't remove any FIXMEs, or for that matter include any tests. https://github.com/llvm/llvm-project/pull/85541 _

[clang] Resolve FIXME: Look at E, not M (PR #85541)

efriedma-quic wrote: https://github.com/llvm/llvm-project/blob/c0f8be4fcfb725d53841d4b17a68685e2a79/clang/lib/CodeGen/CGExpr.cpp#L277 https://github.com/llvm/llvm-project/pull/85541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] Resolve FIXME: Look at E, not M (PR #85541)

rjmccall wrote: Hmm. Well, you'd have to ask @zygoloid what he was thinking in r183721/r183859, but I don't think it's correct in general to be looking at E (the MTE sub-expression) for most of the logic here. IIRC, the MTE sub-expression is essentially the initializer for the materialized t

[clang] Resolve FIXME: Look at E, not M (PR #85541)

zygoloid wrote: IIRC the issue here is that in C++98, the MTE is in a "weird" place in the AST, because of the different rules governing how and when temporaries are formed. For example, for `const int &r = C().a[0];`, we'll form an MTE wrapping just the `C()` expression, converting it to an x

[clang] Resolve FIXME: Look at E, not M (PR #85541)

rjmccall wrote: Hmm. The best solution there is probably to use a consistent representation but introduce some sort of `GLValueThatTheStandardAbsurdlyPretendsIsAnRValue` (definitely the only and best word for this, ship it) that we can use as the value category. IIRC, something similar happe

[clang] Resolve FIXME: Look at E, not M (PR #85541)

https://github.com/RSilicon closed https://github.com/llvm/llvm-project/pull/85541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Resolve FIXME: Look at E, not M (PR #85541)

mizvekov wrote: > Hmm. The best solution there is probably to use a consistent representation > but introduce some sort of `GLValueThatTheStandardAbsurdlyPretendsIsAnRValue` > (definitely the only and best word for this, ship it) that we can use as the > value category. IIRC, something similar