[clang] Template Diagnostic Improvements (PR #99933)

bradenhelmer wrote: I don't have write access, if someone could merge that would be great! https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/cor3ntin approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/mizvekov approved this pull request. These updated test changes still LGTM. https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/bradenhelmer updated https://github.com/llvm/llvm-project/pull/99933 >From 1aaa6ff0f1843f10606064f6b285c7070aaa5b44 Mon Sep 17 00:00:00 2001 From: Braden Helmer Date: Mon, 22 Jul 2024 16:46:04 -0400 Subject: [PATCH 1/4] Fix template error message --- clang/lib/Parse/ParseSt

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/mizvekov approved this pull request. LGTM, Thanks! Please give it a couple of days before merging, in case anyone else wants to chime in. https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@list

[clang] Template Diagnostic Improvements (PR #99933)

bradenhelmer wrote: This is handling the other non-local case now, and the release notes have been updated. The local class case was already being handled. https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@lists.

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/bradenhelmer updated https://github.com/llvm/llvm-project/pull/99933 >From 1aaa6ff0f1843f10606064f6b285c7070aaa5b44 Mon Sep 17 00:00:00 2001 From: Braden Helmer Date: Mon, 22 Jul 2024 16:46:04 -0400 Subject: [PATCH 1/3] Fix template error message --- clang/lib/Parse/ParseSt

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/bradenhelmer updated https://github.com/llvm/llvm-project/pull/99933 >From 1aaa6ff0f1843f10606064f6b285c7070aaa5b44 Mon Sep 17 00:00:00 2001 From: Braden Helmer Date: Mon, 22 Jul 2024 16:46:04 -0400 Subject: [PATCH 1/2] Fix template error message --- clang/lib/Parse/ParseSt

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/mizvekov commented: Hi. The change looks good. There are some other examples of bad diagnostics in that issue, and it would be ideal if they are preserved in case this PR closes that issue. Please also add an entry to `clang/docs/ReleaseNotes.rst`. https://github.com/llvm/

[clang] Template Diagnostic Improvements (PR #99933)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Braden Helmer (bradenhelmer) Changes This is for #17959. It turns out `SemaTemplate` handles this type of diagnostic already, however when template gets encountered, it never gets parsed as a possible statement or declaration, only as

[clang] Template Diagnostic Improvements (PR #99933)

https://github.com/bradenhelmer created https://github.com/llvm/llvm-project/pull/99933 This is for #17959. It turns out `SemaTemplate` handles this type of diagnostic already, however when template gets encountered, it never gets parsed as a possible statement or declaration, only as an ex