[clang] bd87916 - [clang] Add no_builtin attribute

2019-10-28 Thread Guillaume Chatelet via cfe-commits
Author: Guillaume Chatelet Date: 2019-10-28T17:30:11+01:00 New Revision: bd87916109483d33455cbf20da2309197b983cdd URL: https://github.com/llvm/llvm-project/commit/bd87916109483d33455cbf20da2309197b983cdd DIFF: https://github.com/llvm/llvm-project/commit/bd87916109483d33455cbf20da2309197b983cdd.

Re: [clang] bd87916 - [clang] Add no_builtin attribute

2019-10-28 Thread Vlad Tsyrklevich via cfe-commits
I've reverted this change as it was causing ASan/MSan failures in check-clang, e.g. take a look at the bottom 2 failures here: http://lab.llvm.org:8014/builders/sanitizer-x86_64-linux-bootstrap/builds/124/steps/check-clang%20asan/logs/stdio or here http://lab.llvm.org:8014/builders/sanitizer-x86_64

Re: [clang] bd87916 - [clang] Add no_builtin attribute

2019-10-29 Thread Guillaume Chatelet via cfe-commits
hi Vlad, I've spend a big part of my day digging into this and I'm less and less convinced that my patch broke the builds. IIUC the built bots are still failing although my patch has been reverted for quite some time now. Am I missing something? On Mon, Oct 28, 2019 at 11:24 PM Vlad Tsyrklevich

Re: [clang] bd87916 - [clang] Add no_builtin attribute

2019-10-29 Thread Guillaume Chatelet via cfe-commits
For instance here are the kind of errors I have by running a sanitized clang on master (with or without my patch it doesn't make a difference) cd /redacted/git/llvm-project/llvm/build-msan && > /redacted/git/llvm-project/llvm/build-msan/bin/llvm-tblgen > -gen-opt-parser-defs -I /redacted/git/llvm-

Re: [clang] bd87916 - [clang] Add no_builtin attribute

2019-10-29 Thread Vlad Tsyrklevich via cfe-commits
Yup, I didn't follow up to this email but we talked on gchat and sorted it out. On Tue, Oct 29, 2019 at 2:20 PM Vitaly Buka wrote: > Ignoring "slave lost exception" bots are green for a while > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast?numbuilds=100 > > http://lab.llvm.org:80

Re: [clang] bd87916 - [clang] Add no_builtin attribute

2019-10-29 Thread Vitaly Buka via cfe-commits
Ignoring "slave lost exception" bots are green for a while http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast?numbuilds=100 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap?numbuilds=100 Vlads report was done when bots were on staging master :8014 for github migration.