On Fri, Feb 28, 2020 at 11:42 AM Arthur O'Dwyer
wrote:
> On Fri, Feb 28, 2020 at 11:23 AM James Y Knight via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Fri, Feb 28, 2020 at 10:05 AM Aaron Ballman
>> wrote:
>>
>>> On Thu, Feb 27, 2020 at 6:04 PM James Y Knight
>>> wrote:
>>> >
On Fri, Feb 28, 2020 at 11:23 AM James Y Knight via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Feb 28, 2020 at 10:05 AM Aaron Ballman
> wrote:
>
>> On Thu, Feb 27, 2020 at 6:04 PM James Y Knight
>> wrote:
>> >
>> > But, even with all that, I'm not sure why we shouldn't implement
On Fri, Feb 28, 2020 at 10:05 AM Aaron Ballman
wrote:
> On Thu, Feb 27, 2020 at 6:04 PM James Y Knight
> wrote:
> >
> > That all makes sense -- especially the bits about the dates needing to
> be different.
> >
> > But, even with all that, I'm not sure why we shouldn't implement both
>
On Thu, Feb 27, 2020 at 6:04 PM James Y Knight wrote:
>
> That all makes sense -- especially the bits about the dates needing to be
> different.
>
> But, even with all that, I'm not sure why we shouldn't implement both
> __has_cpp_attribute AND __has_c_attribute in C++ mode?
>
> The subset of C
That all makes sense -- especially the bits about the dates needing to be
different.
But, even with all that, I'm not sure why we shouldn't implement both
__has_cpp_attribute AND __has_c_attribute in C++ mode?
The subset of C attributes which retain their C-defined semantics in C++
(which,
On Mon, Nov 25, 2019 at 5:59 PM James Y Knight wrote:
>
> Isn't this unnecessarily annoying to users? You have the same syntax to use
> the attributes, and the attributes are expected to be compatible when named
> the same way, but you can't use the same #if conditional to check for
>
Isn't this unnecessarily annoying to users? You have the same syntax to use
the attributes, and the attributes are expected to be compatible when named
the same way, but you can't use the same #if conditional to check for
availability, when writing a header intended to work in both modes?
On Mon,
Author: Aaron Ballman
Date: 2019-11-25T17:35:12-05:00
New Revision: d930ed1acc0ea49d4b3aae7e95b4c6d9cd310578
URL:
https://github.com/llvm/llvm-project/commit/d930ed1acc0ea49d4b3aae7e95b4c6d9cd310578
DIFF:
https://github.com/llvm/llvm-project/commit/d930ed1acc0ea49d4b3aae7e95b4c6d9cd310578.diff
