[clang] fix issue 73559. (PR #74926)

https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 9b703f6fcdb67eb921b3b5cf67b92bbd24144cf9 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Tue, 19 Dec 2023 05:14:06 +0100 Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only

[clang] fix issue 73559. (PR #74926)

shafik wrote: In the future please add a more description title to your PR. Your summary is great though. Also in this case this is a clang and parser fix so you should prefix your title with `[Clang][Parser]` https://github.com/llvm/llvm-project/pull/74926 ___

[clang] fix issue 73559. (PR #74926)

@@ -641,6 +641,8 @@ Bug Fixes in This Version Fixes (`#67317 `_) - Clang now properly diagnoses use of stand-alone OpenMP directives after a label (including ``case`` or ``default`` labels). +- Fix crash when using C++ only

[clang] fix issue 73559. (PR #74926)

ChipsSpectre wrote: The changes are squashed into one commit now. Sorry for the force push, it was needed to rebase on main. Do you think it can be merged now? https://github.com/llvm/llvm-project/pull/74926 ___ cfe-commits mailing list cfe-commits@l

[clang] fix issue 73559. (PR #74926)

https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From f5029be3d1dc8714cd4ccb42efe4c1f07c1c7dd0 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sun, 17 Dec 2023 10:09:16 +0100 Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only

[mlir] [clang] fix issue 73559. (PR #74926)

https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 8a3e710de9122ac74ab886f8878e01893c19ee87 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sun, 17 Dec 2023 10:01:39 +0100 Subject: [PATCH 1/4] [clang][Parse] `TryAnnotateCXXScopeToken` to be called o

[mlir] [clang] fix issue 73559. (PR #74926)

https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 8a3e710de9122ac74ab886f8878e01893c19ee87 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sun, 17 Dec 2023 10:01:39 +0100 Subject: [PATCH 1/3] [clang][Parse] `TryAnnotateCXXScopeToken` to be called o

[mlir] [clang] fix issue 73559. (PR #74926)

https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 8a3e710de9122ac74ab886f8878e01893c19ee87 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sun, 17 Dec 2023 10:01:39 +0100 Subject: [PATCH 1/2] [clang][Parse] `TryAnnotateCXXScopeToken` to be called o

[mlir] [clang] fix issue 73559. (PR #74926)

https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 8a3e710de9122ac74ab886f8878e01893c19ee87 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sun, 17 Dec 2023 10:01:39 +0100 Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only

[mlir] [clang] fix issue 73559. (PR #74926)

https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From dad78484118bbd0a662915df0b4ce50c24d3bf42 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sat, 9 Dec 2023 12:07:02 +0100 Subject: [PATCH 1/2] fix issue 73559. --- clang/lib/Parse/ParseDecl.cpp|

[mlir] [clang] fix issue 73559. (PR #74926)

Andrzej =?utf-8?q?Warzyński?= ,ChipsSpectre Message-ID: In-Reply-To: https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From dad78484118bbd0a662915df0b4ce50c24d3bf42 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sat, 9 Dec 2023 12:07:02 +0100 Subjec

[mlir] [clang] fix issue 73559. (PR #74926)

Andrzej =?utf-8?q?Warzyński?= ,ChipsSpectre ,ChipsSpectre Message-ID: In-Reply-To: https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From dad78484118bbd0a662915df0b4ce50c24d3bf42 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sat, 9 Dec 2023 12:07:0

[clang] fix issue 73559. (PR #74926)

@@ -2702,7 +2702,7 @@ Parser::ParseCXXClassMemberDeclaration(AccessSpecifier AS, bool MalformedTypeSpec = false; if (!TemplateInfo.Kind && Tok.isOneOf(tok::identifier, tok::coloncolon, tok::kw___super)) { -if (TryAnnotateCXXScopeToken()) +if (getLangOpts().CPl

[clang] fix issue 73559. (PR #74926)

https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/74926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix issue 73559. (PR #74926)

@@ -2702,7 +2702,7 @@ Parser::ParseCXXClassMemberDeclaration(AccessSpecifier AS, bool MalformedTypeSpec = false; if (!TemplateInfo.Kind && Tok.isOneOf(tok::identifier, tok::coloncolon, tok::kw___super)) { -if (TryAnnotateCXXScopeToken()) +if (getLangOpts().CPl

[clang] fix issue 73559. (PR #74926)

https://github.com/Fznamznon commented: Could you please add a test, somewhere in `clang/test/Parser` (there is also a lot of other tests showing how it is done) and a release note to `clang/docs/ReleaseNotes.rst`, perhaps at the end of the list under `Bug Fixes in This Version` heading. http

[clang] fix issue 73559. (PR #74926)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (ChipsSpectre) Changes As stated in this issue, https://github.com/llvm/llvm-project/issues/73559, clang (C version of clang, not C++) crashes when C++ components are parsed. Even a file which only contains a double-colon "::" leads

[clang] fix issue 73559. (PR #74926)

https://github.com/ChipsSpectre created https://github.com/llvm/llvm-project/pull/74926 As stated in this issue, https://github.com/llvm/llvm-project/issues/73559, clang (C version of clang, not C++) crashes when C++ components are parsed. Even a file which only contains a double-colon "::" le