silee2 wrote:
@antiagainst Thanks for the detailed review and helpful comments! Updated the
PR accordingly.
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> {
];
}
+def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> {
+ let summary = "Attaches an SPIRV target attribute to a GPU Module.";
+ let description = [{
+This pass searches for all
@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> {
];
}
+def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> {
+ let summary = "Attaches an SPIRV target attribute to a GPU Module.";
+ let description = [{
+This pass searches for all
@@ -0,0 +1,7 @@
+// RUN: mlir-opt %s --spirv-attach-target='module=spirv.* ver=v1.0
caps=Kernel' | FileCheck %s
+
+module attributes {gpu.container_module} {
+// CHECK: @spirv_module_1 [#spirv.target,
resource_limits = <>>]
+gpu.module @spirv_module_1 {
silee2 w
@@ -0,0 +1,94 @@
+//===- SPIRVAttachTarget.cpp - Attach an SPIRV target
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,94 @@
+//===- SPIRVAttachTarget.cpp - Attach an SPIRV target
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,94 @@
+//===- SPIRVAttachTarget.cpp - Attach an SPIRV target
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,94 @@
+//===- SPIRVAttachTarget.cpp - Attach an SPIRV target
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -166,4 +166,35 @@ def SPIRV_ResourceLimitsAttr :
SPIRV_Attr<"ResourceLimits", "resource_limits"> {
let assemblyFormat = "`<` struct(params) `>`";
}
+//===--===//
+// SPIRV target attribute.
-
@@ -0,0 +1,30 @@
+//===- Target.h - MLIR SPIRV target registration *- C++
-*-===//
silee2 wrote:
Done.
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llv
@@ -166,4 +166,35 @@ def SPIRV_ResourceLimitsAttr :
SPIRV_Attr<"ResourceLimits", "resource_limits"> {
let assemblyFormat = "`<` struct(params) `>`";
}
+//===--===//
+// SPIRV target attribute.
+//===---
@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> {
];
}
+def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> {
+ let summary = "Attaches an SPIRV target attribute to a GPU Module.";
silee2 wrote:
Done.
https://github.co
https://github.com/silee2 updated
https://github.com/llvm/llvm-project/pull/69949
>From 1a4319cff8d95d5a6a6598f94162be28e56d68a8 Mon Sep 17 00:00:00 2001
From: "Lee, Sang Ik"
Date: Mon, 23 Oct 2023 17:23:54 +
Subject: [PATCH 1/5] [MLIR] SPIRV Target Attribute
Create SPIRV Target Attribute
@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> {
];
}
+def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> {
+ let summary = "Attaches an SPIRV target attribute to a GPU Module.";
+ let description = [{
+This pass searches for all
@@ -0,0 +1,117 @@
+//===- Target.cpp - MLIR SPIRV target compilation ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,30 @@
+//===- Target.h - MLIR SPIRV target registration *- C++
-*-===//
antiagainst wrote:
Nit: again, please use SPIR-V in docs and comments.
https://github.com/llvm/llvm-project/pull/69949
___
@@ -166,4 +166,35 @@ def SPIRV_ResourceLimitsAttr :
SPIRV_Attr<"ResourceLimits", "resource_limits"> {
let assemblyFormat = "`<` struct(params) `>`";
}
+//===--===//
+// SPIRV target attribute.
+//===---
@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> {
];
}
+def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> {
+ let summary = "Attaches an SPIRV target attribute to a GPU Module.";
antiagainst wrote:
Nit: s/SPIRV/SPIR-V
@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> {
];
}
+def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> {
+ let summary = "Attaches an SPIRV target attribute to a GPU Module.";
+ let description = [{
+This pass searches for all
@@ -0,0 +1,94 @@
+//===- SPIRVAttachTarget.cpp - Attach an SPIRV target
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -166,4 +166,35 @@ def SPIRV_ResourceLimitsAttr :
SPIRV_Attr<"ResourceLimits", "resource_limits"> {
let assemblyFormat = "`<` struct(params) `>`";
}
+//===--===//
+// SPIRV target attribute.
-
@@ -0,0 +1,117 @@
+//===- Target.cpp - MLIR SPIRV target compilation ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,117 @@
+//===- Target.cpp - MLIR SPIRV target compilation ---*- C++
-*-===//
antiagainst wrote:
Nit: again, please use SPIR-V in docs and comments. Please make sure everywhere
follows the convention. :)
https://github.com/llvm/llvm-proje
https://github.com/antiagainst edited
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
antiagainst wrote:
Thanks for the contribution and sorry about the delay! I'm getting around to
review this pull request (already done a few others). Please wait a bit.
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-
https://github.com/fabianmcg approved this pull request.
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silee2 wrote:
check-flang failed on Windows with two unresolved tests. Does not look related
to this PR. Merging main again to run CI again.
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/silee2 updated
https://github.com/llvm/llvm-project/pull/69949
>From 1a4319cff8d95d5a6a6598f94162be28e56d68a8 Mon Sep 17 00:00:00 2001
From: "Lee, Sang Ik"
Date: Mon, 23 Oct 2023 17:23:54 +
Subject: [PATCH 1/3] [MLIR] SPIRV Target Attribute
Create SPIRV Target Attribute
28 matches
Mail list logo
