https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7050ff4615d7341eab7fca821b061b3fe3dd4bd8
cc76b72371488fba04915132f3ffd8496891c193 --
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/66636
>From 4ea4e89cb47ed7e4d3f1cf2a9d99d2f7e9ad33bb Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 25 Aug 2023 14:07:32 -0400
Subject: [PATCH] [clang] remove ClassScopeFunctionSpecializationDecl
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/66636
>From 9a8db570fab063209a7998bbf631765419034d74 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 25 Aug 2023 14:07:32 -0400
Subject: [PATCH 1/5] [clang] remove ClassScopeFunctionSpecializationDecl
sdkrystian wrote:
@AaronBallman I don't have write access, so that would be appreciated . I was
putting off rebasing incase there were more responses to my comments, but I
presume that there won't be so I will get it rebased now
https://github.com/llvm/llvm-project/pull/66636
@@ -46,6 +46,9 @@ C/C++ Language Potentially Breaking Changes
C++ Specific Potentially Breaking Changes
-
+- The `ClassScopeFunctionSpecializationDecl` AST node has been removed.
Dependent class scope
+explicit function template
sdkrystian wrote:
Updated the release notes. I didn't go into exhaustive detail, but I can add
more if anyone here deems it necessary @erichkeane @AaronBallman
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/66636
>From d11d546f3190936ba45c57b4825073026d817878 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 25 Aug 2023 14:07:32 -0400
Subject: [PATCH 1/4] [clang] remove ClassScopeFunctionSpecializationDecl
@@ -752,8 +745,6 @@ class CollectExtraHighlightings
}
if (auto *Args = D->getTemplateSpecializationArgsAsWritten())
H.addAngleBracketTokens(Args->getLAngleLoc(), Args->getRAngleLoc());
-if (auto *I = D->getDependentSpecializationInfo())
-
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/66636
>From d11d546f3190936ba45c57b4825073026d817878 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 25 Aug 2023 14:07:32 -0400
Subject: [PATCH 1/3] [clang] remove ClassScopeFunctionSpecializationDecl
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2154,6 +2144,15 @@ bool
RecursiveASTVisitor::TraverseFunctionHelper(FunctionDecl *D) {
TALI->NumTemplateArgs));
}
}
+// FIXME: Do we want to traverse the explicit template arguments for
@@ -1481,10 +1481,6 @@ enum DeclCode {
/// template template parameter pack.
DECL_EXPANDED_TEMPLATE_TEMPLATE_PARM_PACK,
- /// A ClassScopeFunctionSpecializationDecl record a class scope
- /// function specialization. (Microsoft extension).
-
erichkeane wrote:
I don't have any comments, though someone with knowledge of teh
clang-tools-extra stuff would be nice to take a look, as well as someone
familiar with the serialization. @AaronBallman .
ALSO, this might need a release note and does this need to be mailed to the
'breaking
sdkrystian wrote:
Ping @erichkeane & @shafik -- I left comments responding to your feedback
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/66636
>From d11d546f3190936ba45c57b4825073026d817878 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 25 Aug 2023 14:07:32 -0400
Subject: [PATCH 1/2] [clang] remove ClassScopeFunctionSpecializationDecl
https://github.com/sdkrystian resolved
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian resolved
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian resolved
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian resolved
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/66636
>From d11d546f3190936ba45c57b4825073026d817878 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 25 Aug 2023 14:07:32 -0400
Subject: [PATCH 1/2] [clang] remove ClassScopeFunctionSpecializationDecl
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/66636
>From d11d546f3190936ba45c57b4825073026d817878 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 25 Aug 2023 14:07:32 -0400
Subject: [PATCH 1/2] [clang] remove ClassScopeFunctionSpecializationDecl
@@ -4086,7 +4073,7 @@ FunctionDecl
*Sema::SubstSpaceshipAsEqualEqual(CXXRecordDecl *RD,
Decl *R;
if (auto *MD = dyn_cast(Spaceship)) {
R = Instantiator.VisitCXXMethodDecl(
-MD, nullptr, std::nullopt,
+MD, nullptr,
shafik wrote:
To be
@@ -1016,21 +1003,20 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD)
{
}
case FunctionDecl::TK_DependentFunctionTemplateSpecialization: {
// Templates.
-UnresolvedSet<8> TemplDecls;
-unsigned NumTemplates = Record.readInt();
-while
https://github.com/shafik commented:
Mostly minor fixes and or questions.
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -67,7 +67,7 @@ AST_MATCHER_P(CallExpr, hasLastArgument,
// function had parameters defined (this is useful to check if there is only
one
// variadic argument).
AST_MATCHER(CXXMemberCallExpr, hasSameNumArgsAsDeclNumParams) {
- if
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2613,70 +2579,6 @@ class TypeAliasTemplateDecl : public
RedeclarableTemplateDecl {
static bool classofKind(Kind K) { return K == TypeAliasTemplate; }
};
-/// Declaration of a function specialization at template class scope.
-///
-/// For example:
-/// \code
-///
https://github.com/erichkeane commented:
I guess my first question is 'why'? My second is 'if this is unnecessary, why
was it here in the first place?`. I'd like some level of historical analysis
here/perhaps the knowledge of @zygoloid.
https://github.com/llvm/llvm-project/pull/66636
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
30 matches
Mail list logo
