[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/PeterChou1 closed https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97681 >From f9d5cc074e4b65a92703bd09e62696a29fed1237 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 4 Jul 2024 01:31:13 -0400 Subject: [PATCH 1/7] [clang-doc] add nested naemspace --- .../test/clang-doc/name

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/ilovepi approved this pull request. LGTM, once the LINE checks are in a more stable position w/ their own prefixes, and a couple of nits on whitespace. https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

@@ -0,0 +1,274 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=html --output=%t --executor=standalone %s +// RUN: clang-doc --format=md --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/index_json.js -check-prefix=JSON-INDEX +// RUN: FileCheck %s < %

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

@@ -0,0 +1,274 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=html --output=%t --executor=standalone %s +// RUN: clang-doc --format=md --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/index_json.js -check-prefix=JSON-INDEX +// RUN: FileCheck %s < %

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

PeterChou1 wrote: > To clarify my earlier comment, FileCheck is just matching text on the input > based on the check lines. So in this cases the LINE directive should just > affect what text will be accepted when doin matching. It won’t try to match > the lines to the position in the file bein

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97681 >From f9d5cc074e4b65a92703bd09e62696a29fed1237 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 4 Jul 2024 01:31:13 -0400 Subject: [PATCH 1/6] [clang-doc] add nested naemspace --- .../test/clang-doc/name

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

ilovepi wrote: To clarify my earlier comment, FileCheck is just matching text on the input based on the check lines. So in this cases the LINE directive should just affect what text will be accepted when doin matching. It won’t try to match the lines to the position in the file being checked.

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

@@ -0,0 +1,270 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=html --output=%t --executor=standalone %s +// RUN: clang-doc --format=md --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/index_json.js -check-prefix=JSON-INDEX +// RUN: FileCheck %s < %

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

ilovepi wrote: > I don't think this possible since the line directive matches the line of the > html or md file you pipe into FileCheck, which is different from the line > that's define in the source code. I've opted for just matching any number to > make the test case less brittle I’m not s

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

PeterChou1 wrote: > I think this mostly looks good, but I am concerned with the line number > matching. It appears that whenever you’ve up’s the file you’ve had to update > all the line numbers. > > Is it feasible to rewrite some of the checks to use the “LINE” directive? > Perhaps it also ma

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97681 >From f9d5cc074e4b65a92703bd09e62696a29fed1237 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 4 Jul 2024 01:31:13 -0400 Subject: [PATCH 1/5] [clang-doc] add nested naemspace --- .../test/clang-doc/name

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/ilovepi commented: I think this mostly looks good, but I am concerned with the line number matching. It appears that whenever you’ve up’s the file you’ve had to update all the line numbers. Is it feasible to rewrite some of the checks to use the @LINE directive? Perhaps i

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97681 >From f9d5cc074e4b65a92703bd09e62696a29fed1237 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 4 Jul 2024 01:31:13 -0400 Subject: [PATCH 1/4] [clang-doc] add nested naemspace --- .../test/clang-doc/name

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97681 >From f9d5cc074e4b65a92703bd09e62696a29fed1237 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 4 Jul 2024 01:31:13 -0400 Subject: [PATCH 1/3] [clang-doc] add nested naemspace --- .../test/clang-doc/name

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

@@ -0,0 +1,340 @@ +// RUN: clang-doc --format=html --output=%t/docs --executor=standalone %s +// RUN: clang-doc --format=md --output=%t/docs --executor=standalone %s ilovepi wrote: Why no `mkdir`? I presume because clang-doc will make it, but the test shouldn't

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

@@ -0,0 +1,340 @@ +// RUN: clang-doc --format=html --output=%t/docs --executor=standalone %s +// RUN: clang-doc --format=md --output=%t/docs --executor=standalone %s +// RUN: FileCheck %s -input-file=%t/docs/index_json.js -check-prefix=JSON-INDEX +// RUN: FileCheck %s -input-file=

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97681 >From f9d5cc074e4b65a92703bd09e62696a29fed1237 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 4 Jul 2024 01:31:13 -0400 Subject: [PATCH 1/2] [clang-doc] add nested naemspace --- .../test/clang-doc/name

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (PeterChou1) Changes This patch adds a test to clang-doc which test the nested namespace generation of clang-doc --- Full diff: https://github.com/llvm/llvm-project/pull/97681.diff 1 Files Affected: - (added) clang-too

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

https://github.com/PeterChou1 created https://github.com/llvm/llvm-project/pull/97681 This patch adds a test to clang-doc which test the nested namespace generation of clang-doc >From f9d5cc074e4b65a92703bd09e62696a29fed1237 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 4 Jul 2024 01:3