PiotrZSL wrote:
Rebased, bump
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/66553
>From 8c9f81796c93d4309eb8711ff35d897b2088dbe4 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Fri, 15 Sep 2023 21:39:17 +
Subject: [PATCH 1/3] [clang-tidy] Fix handling --driver-mode=
Driver mode passed
AdityaShantanu wrote:
bump.
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/66553
>From f4f9c996171892813dc11eb5bcb29e0616475f40 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Fri, 15 Sep 2023 21:39:17 +
Subject: [PATCH 1/3] [clang-tidy] Fix handling --driver-mode=
Driver mode passed
@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr
createBaseFS() {
return BaseFS;
}
+static void recreateOptionsParserIfNeeded(
+llvm::Expected ,
+llvm::ArrayRef Args,
+const ClangTidyOptions ) {
+
+ auto DoubleDashIt = std::find(Args.begin(), Args.end(),
@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr
createBaseFS() {
return BaseFS;
}
+static void recreateOptionsParserIfNeeded(
+llvm::Expected ,
+llvm::ArrayRef Args,
+const ClangTidyOptions ) {
+
+ auto DoubleDashIt = std::find(Args.begin(), Args.end(),
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr
createBaseFS() {
return BaseFS;
}
+static void recreateOptionsParserIfNeeded(
+llvm::Expected ,
+llvm::ArrayRef Args,
+const ClangTidyOptions ) {
+
+ auto DoubleDashIt = std::find(Args.begin(), Args.end(),
@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr
createBaseFS() {
return BaseFS;
}
+static void recreateOptionsParserIfNeeded(
+llvm::Expected ,
+llvm::ArrayRef Args,
+const ClangTidyOptions ) {
+
+ auto DoubleDashIt = std::find(Args.begin(), Args.end(),
@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr
createBaseFS() {
return BaseFS;
}
+static void recreateOptionsParserIfNeeded(
+llvm::Expected ,
+llvm::ArrayRef Args,
+const ClangTidyOptions ) {
+
+ auto DoubleDashIt = std::find(Args.begin(), Args.end(),
https://github.com/5chmidti commented:
I don't know enough about the driver to approve this, but I read this a few
times and I think that this is correct. I just added a few small and
non-functional nits
https://github.com/llvm/llvm-project/pull/66553
rsniezek wrote:
nevermind, managed to do it. had to split "-isystem" and the path to separate
--extra-arg-before and it worked. thanks agian!
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsniezek wrote:
you are right, when prepended path to clang headres the check don't crash even
with full compile commands after the --
```
/run/current-system/sw/bin/clang-tidy --checks=* -p
/home/rsniezek/workspace/testings_stuff/build
--extra-arg-before=--driver-mode=g++
PiotrZSL wrote:
@rsniezek No thats diffrent issue, you need to use xmmintrin.h from clang,
usually it should work by default, but maybe clang-tidy and clang are installed
in different folders. In such case you may need to add explicitly -isystem to
location of xmmintrin.h
rsniezek wrote:
Let's move discussion from the other topic here.
I have this minimalistic reproduction example:
main.cpp
```cpp
#include
int main() { return 0; }
```
With CMakeLists.txt:
```cmake
cmake_minimum_required(VERSION 3.26)
project(testexe)
set(CMAKE_CXX_STANDARD 23)
PiotrZSL wrote:
@rsniezek If someone will review & approve it, then it will land.
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsniezek wrote:
Is there any chance this could land in the near future? CMake is currenlty
passing the driver mode as extra-arg-before which, as I understand, is not
utilized without this PR. I've opened an issue on cmake to pass the driver mode
after the -- delimiter but not sure if this
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/66553
>From d67dbfb1e926e90b2f4a067c86732bd41783791d Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Fri, 15 Sep 2023 21:39:17 +
Subject: [PATCH 1/2] [clang-tidy] Fix handling --driver-mode=
Driver mode passed
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/66553
>From d67dbfb1e926e90b2f4a067c86732bd41783791d Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Fri, 15 Sep 2023 21:39:17 +
Subject: [PATCH] [clang-tidy] Fix handling --driver-mode=
Driver mode passed as
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -525,8 +527,95 @@ static bool verifyFileExtensions(
return AnyInvalid;
}
+static SmallString<256> makeAbsolute(llvm::StringRef Input) {
+ if (Input.empty())
+return {};
+ SmallString<256> AbsolutePath(Input);
+ if (std::error_code EC =
PiotrZSL wrote:
If anyone see any other alternative implementations or see some potential
issues, then any comments are welcome.
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/66553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Changes
Driver mode passed as an extra argument (command line or config) were not
utilized for removing invalid arguments in stripPositionalArgs function, and
even if passed as config driver mode were not used for dependency file striping
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/66553
Driver mode passed as an extra argument (command line or config) were not
utilized for removing invalid arguments in stripPositionalArgs function, and
even if passed as config driver mode were not used for
29 matches
Mail list logo
