https://github.com/MikeWeller edited
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -251,3 +251,10 @@ class Test10 {
Test10(T &&Item, E e)
: e(e){}
};
+
+// A deleted ctor cannot hide anything
+class Test11 {
+public:
+ template
+ Test11(T&&) = delete;
MikeWeller wrote:
Although this is enough to trigger (or not after the fix) t
EugeneZelenko wrote:
Please mention changes in Release Notes.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 4cb9527430d3c7f9acc518427a29eae0aa7e00d1 Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-referenc
https://github.com/MikeWeller ready_for_review
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Mike Weller (MikeWeller)
Changes
Fix `bugprone-forwarding-reference-overload` so it doesn't report a constructor
that is deleted.
---
Full diff: https://github.com/llvm/llvm-project/pull/88138.diff
2 Files Affected:
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Mike Weller (MikeWeller)
Changes
Fix `bugprone-forwarding-reference-overload` so it doesn't report a constructor
that is deleted.
---
Full diff: https://github.com/llvm/llvm-project/pull/88138.diff
2 Files Affected:
- (modi
https://github.com/PiotrZSL commented:
Missing release notes entry, except that looks fine.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
MikeWeller wrote:
Sorry, didn't realize there are release notes I can updated in the change
itself. Will do this Monday.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 4cb9527430d3c7f9acc518427a29eae0aa7e00d1 Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/2] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-referenc
MikeWeller wrote:
Given the small size of the change I just did a rebase and force push to
resolve conflicts with the release notes.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
@@ -102,6 +102,7 @@ Improvements to clang-tidy
similar fashion to what `-header-filter` does for header files.
- Improved :program:`check_clang_tidy.py` script. Added argument
`-export-fixes`
to aid in clang-tidy and test development.
+- Fixed an issue with `bugprone-forwa
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/2] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
MikeWeller wrote:
@PiotrZSL apologies, have put it in the correct location. Is there a way to
preview/check the `:doc:` thing? I assume there is some kind of
preprocessor/tool step for this? I copied what the rest are doing and put the
appropriate section of the
https://clang.llvm.org/extra/c
@@ -287,6 +286,10 @@ Changes in existing checks
check by resolving fix-it overlaps in template code by disregarding implicit
instances.
+- Improved :doc:`bugprone-forwarding-reference-overload
PiotrZSL wrote:
move it to line 149, to keep checks in alphabe
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/3] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
https://github.com/HerrCai0907 approved this pull request.
LGTM in source code part.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -286,6 +286,10 @@ Changes in existing checks
check by resolving fix-it overlaps in template code by disregarding implicit
instances.
+- Improved :doc:`bugprone-forwarding-reference-overload
+ `
+ check to not flag deleted constructors which are unable to hide anything
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/4] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MikeWeller wrote:
FYI I don't have merge privs, not sure if I need to ping anybody. Then again I
still see "This workflow requires approval from a maintainer", possibly because
this is my first contribution?
https://github.com/llvm/llvm-project/pull/88138
__
@@ -286,6 +286,10 @@ Changes in existing checks
check by resolving fix-it overlaps in template code by disregarding implicit
instances.
+- Improved :doc:`bugprone-forwarding-reference-overload
+ `
+ check to not flag deleted constructors which are unable to hide anything
HerrCai0907 wrote:
I can help you to merge it. 😄
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a71565d75e23fc28076aa5bf1c5cf4432623afc5
bab66e16f29367fa44002d9d31c328607c734354 --
HerrCai0907 wrote:
please fix format issue.`git-clang-format` is helpful.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/5] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@MikeWeller Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a bui
30 matches
Mail list logo
