https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/86596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
I will go with merging this. There are still few improvements possible, but
they require partial check rewrite.
I may to work on some PoC. You could test with additional matcher (at the
beginning): `unless(isExpansionInSystemHeader())` and see if excluding system
headers helps
ilovepi wrote:
Well, its down to about 15 minutes from 1hr 40 min, which is a pretty great
improvement. 15 minutes does still seem to be too long for a file that's only
2KLOC. I know its more complex w/ headers and macros, but it does only take
about 1-2 minutes to compile normally, so I feel
https://github.com/ilovepi approved this pull request.
LGTM. Thanks for the quick fix. I’ll try this out later today and let you know
if this completely solves the issue or if there is something else that may
still warrant investigating.
https://github.com/llvm/llvm-project/pull/86596
https://github.com/5chmidti approved this pull request.
LGTM. That's a very nice speedup :)
https://github.com/llvm/llvm-project/pull/86596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Piotr Zegar (PiotrZSL)
Changes
Main problem with performance of this check is caused by hasAncestor matcher,
and to be more precise by an llvm::DenseSet and std::deque in
matchesAnyAncestorOf.
To reduce impact of this
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/86596
Main problem with performance of this check is caused by hasAncestor matcher,
and to be more precise by an llvm::DenseSet and std::deque in
matchesAnyAncestorOf.
To reduce impact of this matcher, multiple
