https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/96203
None
>From 669205c0f659239c58a3bde3ddadabb0a8ecbad8 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 20 Jun 2024 15:05:57 +
Subject: [PATCH] [clang-tidy] add fixhint for misc-use-internal-linkage
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Congcong Cai (HerrCai0907)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/96203.diff
3 Files Affected:
- (modified) clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.cpp
(+10-2)
- (modified)
clang-tool
5chmidti wrote:
The other two functions have fixes as well. I'd argue that template
declarations don't need to be inside anonymous namespaces/`static`, but that's
outside the scope of this pr.
Either way, this pr should check that both have an attached fixit:
@@ -82,11 +82,19 @@ static constexpr StringRef Message =
void UseInternalLinkageCheck::check(const MatchFinder::MatchResult &Result) {
if (const auto *FD = Result.Nodes.getNodeAs("fn")) {
-diag(FD->getLocation(), Message) << "function" << FD;
+DiagnosticBuilder DB =
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/96203
>From 669205c0f659239c58a3bde3ddadabb0a8ecbad8 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 20 Jun 2024 15:05:57 +
Subject: [PATCH 1/2] [clang-tidy] add fixhint for misc-use-internal-linkage
--
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/96203
>From 669205c0f659239c58a3bde3ddadabb0a8ecbad8 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 20 Jun 2024 15:05:57 +
Subject: [PATCH 1/3] [clang-tidy] add fixhint for misc-use-internal-linkage
--
https://github.com/5chmidti approved this pull request.
LGTM from my side
https://github.com/llvm/llvm-project/pull/96203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/96203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -25,3 +25,16 @@ Example:
}
// already declared as extern
extern int v2;
+
+Options
+---
+
+.. option:: FixMode
+
+ Selects the fix mode when fixing automatically.
5chmidti wrote:
Not sure if it is better: `Selects what kind of a fix the check sho
@@ -25,3 +25,16 @@ Example:
}
// already declared as extern
extern int v2;
+
+Options
+---
+
+.. option:: FixMode
+
+ Selects the fix mode when fixing automatically.
HerrCai0907 wrote:
```suggestion
Selects what kind of a fix the check should prov
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/96203
>From 669205c0f659239c58a3bde3ddadabb0a8ecbad8 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 20 Jun 2024 15:05:57 +
Subject: [PATCH 1/4] [clang-tidy] add fixhint for misc-use-internal-linkage
--
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/96203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -25,3 +25,16 @@ Example:
}
// already declared as extern
extern int v2;
+
+Options
+---
+
+.. option:: FixMode
PiotrZSL wrote:
should say what is default value
https://github.com/llvm/llvm-project/pull/96203
__
@@ -25,3 +25,16 @@ Example:
}
// already declared as extern
extern int v2;
+
+Options
+---
+
+.. option:: FixMode
HerrCai0907 wrote:
#96779
https://github.com/llvm/llvm-project/pull/96203
___
cfe-commits
14 matches
Mail list logo
