[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 248c433be176806766f8c2ae9f19ca61f392220e Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 32d56e1bfb79ec0be5344ec11bb465777c2fd236 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

5chmidti wrote: > In general scope of the check is fine, but specially as it's limited to C++20 > and way how its written would be good to rename it into > modernize-use-std-numbers. Sure thing. I don't have a strong feeling about the category. https://github.com/llvm/llvm-project/pull/66583

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

5chmidti wrote: - How do I correctly parse the values in a macro? While the test locally works, it doesn't in CI. I also don't differentiate between what kind of numeric constant the token is, which might be another problem. Any pointers on how to do this correctly are greatly appreciated. -

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

PiotrZSL wrote: In general scope of the check is fine, but specially as it's limited to C++20 and way how its written would be good to rename it into modernize-use-std-numbers. https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 6e14980c7b7fe22e8b614d641ba72117982b798f Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

5chmidti wrote: For macros I have only implemented matching literals, not function calls or formulas. I also don't suggest using modern language constructs for macros, there are other checks that do this. https://github.com/llvm/llvm-project/pull/66583

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes This check finds constants and function calls to math functions that can be replaced with c++20's mathematical constants ('numbers' header) and offers fixit-hints. Does not match the use of variables or macros with that value and

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/66583 This check finds constants and function calls to math functions that can be replaced with c++20's mathematical constants ('numbers' header) and offers fixit-hints. Does not match the use of variables or macros