[clang-tools-extra] [clang-tidy]avoid bugprone-unused-return-value false positive for function with the same prefix as the default argument (PR #84333)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/84333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]avoid bugprone-unused-return-value false positive for function with the same prefix as the default argument (PR #84333)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/84333 >From aaa9ea1db21b5de5d8be454ce1b1d05b219cccfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Mar 2024 23:28:40 +0800 Subject: [PATCH 1/2] [clang-tidy]avoid bugprone-unused-return-value false

[clang-tools-extra] [clang-tidy]avoid bugprone-unused-return-value false positive for function with the same prefix as the default argument (PR #84333)

https://github.com/5chmidti approved this pull request. +1 on the docs https://github.com/llvm/llvm-project/pull/84333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]avoid bugprone-unused-return-value false positive for function with the same prefix as the default argument (PR #84333)

https://github.com/PiotrZSL approved this pull request. LGTM, but I agree that documentation should be changed to put there configuration in format that it is in .cpp file. https://github.com/llvm/llvm-project/pull/84333 ___ cfe-commits mailing list

[clang-tools-extra] [clang-tidy]avoid bugprone-unused-return-value false positive for function with the same prefix as the default argument (PR #84333)

firewave wrote: I think this might also require documentation changes. The documentation is also a bit misleading in terms of the defaults: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/unused-return-value.html. I add issues detecting a custom function as it required the ``::`

[clang-tools-extra] [clang-tidy]avoid bugprone-unused-return-value false positive for function with the same prefix as the default argument (PR #84333)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/84333 >From aaa9ea1db21b5de5d8be454ce1b1d05b219cccfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Mar 2024 23:28:40 +0800 Subject: [PATCH] [clang-tidy]avoid bugprone-unused-return-value false negative

[clang-tools-extra] [clang-tidy]avoid bugprone-unused-return-value false positive for function with the same prefix as the default argument (PR #84333)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/84333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits