[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 06eaf30b75ac4209bdb5768511053d648ac55a55 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From c85ae981ba584df754057e89703a7b1c1554e5aa Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 35456a46409862a31014161978e56f9ad184a7f1 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: @sr-tream just so you know, every time you force-push a PR, github sends every subscriber an email notification https://github.com/llvm/llvm-project/pull/72479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
sr-tream wrote: > @sr-tream just so you know, every time you force-push a PR, github sends > every subscriber an email notification Sorry for flood, I will try to avoid this from now on https://github.com/llvm/llvm-project/pull/72479 ___ cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-20 Thread kadir çetinkaya via cfe-commits
kadircet wrote: hi! thanks for the interest @sr-tream but I am afraid this is likely to cause disruption in more cases than it might improve. apart from technical details like the threading concerns and reliance on certain variants that we don't really have (eg order of includes); at a high l

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-20 Thread via cfe-commits
sr-tream wrote: > apart from technical details like the threading concerns and reliance on > certain variants that we don't really have (eg order of includes); at a high > level the idea of "finding a representative source file for the header and > replicating the PP state" is hard to work in

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-20 Thread kadir çetinkaya via cfe-commits
kadircet wrote: > We can limit ourselves to only the paired source file, and cancel inclusions > if the source file does not include a non-self-contained header directly. > This will reduce the number of situations in which this hack works, but will > avoid the problems you describe deducing

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-20 Thread via cfe-commits
https://github.com/sr-tream closed https://github.com/llvm/llvm-project/pull/72479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-22 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: A somewhat narrow use case where this approach might be workable is unity builds (groups of source files batched together to be compiled as a single translation unit for build performance). That's a situation where the non-self-contained files of interest (the individual

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-15 Thread via cfe-commits
https://github.com/sr-tream created https://github.com/llvm/llvm-project/pull/72479 It's a hack to solve include headers from source to non-self-contained headers Limitations: - header file must be matched by `isHeaderFile` without language options - non-self-contained header must be included b

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: SR_team (sr-tream) Changes It's a hack to solve include headers from source to non-self-contained headers Limitations: - header file must be matched by `isHeaderFile` without language options - non-self-contained header must be included b

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-15 Thread via cfe-commits
https://github.com/sr-tream edited https://github.com/llvm/llvm-project/pull/72479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-15 Thread via cfe-commits
https://github.com/sr-tream edited https://github.com/llvm/llvm-project/pull/72479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-15 Thread via cfe-commits
https://github.com/sr-tream edited https://github.com/llvm/llvm-project/pull/72479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 032fddf0fbb03f0e3da86505aa81634a8a8e1cbc Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 7b0b07e4a9adc5229226addd2700588bc0985c59 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 580ad92c5cbaa88d402b71436ec90b6de325b1d2 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 76bb83ad49840ceb92be2db5bfe7849f5280d6d3 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From bd6a6d0bd766813c770b47115c48333ad7a992cd Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 144b2f579ef06e663cf233431d291a913b895074 76bb83ad49840ceb92be2db5bfe7849f5280d6d3 --

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 225ca71650e880e9584fe2d49e03baba34690883 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too