nico wrote:
Seems like unnecessary complexity to me fwiw. So far, we've put tests for
things that work in the test suite and put a record of things that assert in
the bug tracker :)
https://github.com/llvm/llvm-project/pull/75116
___
cfe-commits mail
mizvekov wrote:
I see, thanks for pointing it out.
I wonder if we support, or otherwise if we should support, a lit requires
marker for this.
https://github.com/llvm/llvm-project/pull/75116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
nico wrote:
I've reverted this for now in d860480f9b20b308a677daf45f7bfe1da2a03ac7.
https://github.com/llvm/llvm-project/pull/75116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
Aha, it assumes that the build is with assertions enabled, which isn't always
true. (Do a release build, or a debug build with `-DLLVM_ENABLE_ASSERTIONS=NO`.)
How about just reverting this and landing the test together with the fix?
https://github.com/llvm/llvm-project/pull/75116
_
nico wrote:
The test is failing on our bots:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8761812675757485889/+/u/package_clang/stdout?format=raw
```
FAIL: Clangd :: GH75115.test (21263 of 79608)
TEST 'Clangd :: GH75115.test' FAILED **
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/75116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/75116
>From 1c9690d87f3a3bbe8389cb9a852d00fe2d3cf478 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 11 Dec 2023 17:36:44 -0300
Subject: [PATCH] [clangd] Add test for GH75115
Add test for https://github.com
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/75116
>From 7c18785d74556001cf19d9ae84c8f32f8d95801e Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 11 Dec 2023 17:36:44 -0300
Subject: [PATCH] [clangd] Add test for GH75115
Add test for https://github.com
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/75116
>From a3971a65e7c7297295a6db154360c205a254c708 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 11 Dec 2023 17:36:44 -0300
Subject: [PATCH] [clangd] Add test for GH75115
Add test for https://github.com
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/75116
>From f3c8adf8b08369ba2e90e237957d4205526f64e1 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 11 Dec 2023 17:36:44 -0300
Subject: [PATCH] [clangd] Add test for GH75115
Add test for https://github.com
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Matheus Izvekov (mizvekov)
Changes
Add test for https://github.com/llvm/llvm-project/issues/75115
---
Full diff: https://github.com/llvm/llvm-project/pull/75116.diff
1 Files Affected:
- (added) clang-tools-extra/clangd/test/GH75115.tes
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/75116
Add test for https://github.com/llvm/llvm-project/issues/75115
>From bd01b0d71c05fa7d728b6db08d14d51fe332ae2c Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 11 Dec 2023 17:36:44 -0300
Subject: [PATCH
12 matches
Mail list logo
