https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/76826
False negative/positive rate has decreased to the degree that these
extra confirmations no longer provide any value, but only create
friction in the happy case.
When we have false analysis, people usually need t
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: kadir çetinkaya (kadircet)
Changes
False negative/positive rate has decreased to the degree that these
extra confirmations no longer provide any value, but only create
friction in the happy case.
When we have false analysis, people usuall
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/76826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein approved this pull request.
This change makes sense for removing all unused includes (as all these unused
includes are visible in the editor). For missing includes, they are less
obvious, but it is probably fine.
(I think it would be great to have a way to view all mi
@@ -237,18 +236,6 @@ removeAllUnusedIncludes(llvm::ArrayRef
UnusedIncludes) {
Diag.Fixes.front().Edits.begin(),
Diag.Fixes.front().Edits.end());
}
-
- // TODO(hokein): emit a suitable text for the label.
- ChangeAnnotat
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/76826
From 5e9a851584dcfd730fda7d85b54101ebea89f8a3 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Wed, 3 Jan 2024 16:06:13 +0100
Subject: [PATCH 1/2] [clangd] Dont require confirmation for include-cleaner
batc
@@ -237,18 +236,6 @@ removeAllUnusedIncludes(llvm::ArrayRef
UnusedIncludes) {
Diag.Fixes.front().Edits.begin(),
Diag.Fixes.front().Edits.end());
}
-
- // TODO(hokein): emit a suitable text for the label.
- ChangeAnnotat
kadircet wrote:
> This change makes sense for removing all unused includes (as all these unused
> includes are visible in the editor). For missing includes, they are less
> obvious, but it is probably fine.
The rationale for missing includes was the same, when things go wrong it's
usually obs
kadircet wrote:
oh sorry, this should ofc work with include-cleaner fixes, as we actually
provide these as edits, instead of commands, as we do with our usual tweaks.
https://github.com/llvm/llvm-project/pull/76826
___
cfe-commits mailing list
cfe-com
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/76826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
10 matches
Mail list logo
