https://github.com/HighCommander4 approved this pull request.
Thanks, the change looks good to me!
I went through the existing callers of `Node::getDeclContext()`, and I was able
to construct a test case where the patch actually changes behaviour (in a good
way):
```c++
namespace NS {
void un
HighCommander4 wrote:
> Happy New Year 2024!
You too!
https://github.com/llvm/llvm-project/pull/76329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
Sorry for being silent for a few days, I've been a bit occupied recently and
hopefully I could get back to the heuristic patch for templates soon.
> I went through the existing callers of Node::getDeclContext(), and I was able
> to construct a test case where the patch actually
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/76329
>From c894b9375ebbd1ab58c33a22297bebcd5394a1af Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sun, 24 Dec 2023 18:08:30 +0800
Subject: [PATCH 1/3] [clangd] Handle lambda scopes inside
Node::getDeclContext()
zyn0217 wrote:
(I'll land it once the CI turns green.)
https://github.com/llvm/llvm-project/pull/76329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/76329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
> Shouldn't it be placed on a new line?
I think what may be happening here is that the refactorings try to avoid
duplicating the work of the formatter, and just generate syntactically valid
code that the formatter will then format according to the codebase's
clang-format
zyn0217 wrote:
The CI failure on windows seems irrelevant, so I'm landing it anyway.
```
FAILED: tools/clang/tools/extra/clangd/CompletionModel.h
tools/clang/tools/extra/clangd/CompletionModel.cpp
cmd.exe /C "cd /D C:\ws\src\build\tools\clang\tools\extra\clangd &&
C:\Python39\python.exe
C:/ws
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/76329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/76329
We used to consider the `DeclContext` for selection nodes inside a lambda as
the enclosing scope of the lambda expression, rather than the lambda itself.
For example,
```cpp
void foo();
auto lambda = [] {
ret
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Younan Zhang (zyn0217)
Changes
We used to consider the `DeclContext` for selection nodes inside a lambda as
the enclosing scope of the lambda expression, rather than the lambda itself.
For example,
```cpp
void foo();
auto lambda = [] {
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/76329
>From c0b04507075b39e494d3e6fa39168bc47b92f338 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sun, 24 Dec 2023 18:08:30 +0800
Subject: [PATCH 1/2] [clangd] Handle lambda scopes inside
Node::getDeclContext()
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/76329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
Ping. And Happy New Year 2024!
https://github.com/llvm/llvm-project/pull/76329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
14 matches
Mail list logo