https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/109508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/109508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0cab475d1126305dc1bbb2ba269e40d704dfb90f
39dea55ef4af49f1d855d78a70a5b5f535e44405 --e
https://github.com/kazutakahirata updated
https://github.com/llvm/llvm-project/pull/109508
>From d50b829fd1277736b7e65886879fcfe9a45714f2 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Fri, 20 Sep 2024 13:31:12 -0700
Subject: [PATCH 1/3] [modularize] Avoid repeated hash lookups (NFC)
---
cl
kazutakahirata wrote:
Revised the patch. Please take a look. Thanks!
https://github.com/llvm/llvm-project/pull/109508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata updated
https://github.com/llvm/llvm-project/pull/109508
>From d50b829fd1277736b7e65886879fcfe9a45714f2 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Fri, 20 Sep 2024 13:31:12 -0700
Subject: [PATCH 1/2] [modularize] Avoid repeated hash lookups (NFC)
---
cl
@@ -508,13 +508,11 @@ class EntityMap : public std::map> {
// Sort contents.
llvm::sort(H->second);
- // Check whether we've seen this header before.
- auto KnownH = AllHeaderContents.find(H->first);
- if (KnownH == AllHeaderContents.end()) {
-
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/109508.diff
1 Files Affected:
- (modified) clang-tools-extra/modularize/Modularize.cpp (+4-6)
``diff
diff --git a/clan
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/109508
None
>From d50b829fd1277736b7e65886879fcfe9a45714f2 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Fri, 20 Sep 2024 13:31:12 -0700
Subject: [PATCH] [modularize] Avoid repeated hash lookups (NFC)
---
