Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

2020-07-21 Thread David Blaikie via cfe-commits
Cool - thanks for the context! On Tue, Jul 21, 2020 at 5:44 AM Aaron Ballman wrote: > On Mon, Jul 20, 2020 at 5:44 PM David Blaikie wrote: > > > > Should the warning be disabled for LLVM overall, rather than only for > > this subproject? (& be good tohave some details in the commit at least > >

Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

2020-07-21 Thread Aaron Ballman via cfe-commits
On Mon, Jul 20, 2020 at 5:44 PM David Blaikie wrote: > > Should the warning be disabled for LLVM overall, rather than only for > this subproject? (& be good tohave some details in the commit at least > of why this warning is being disabled - how it is noisy/unhelpful/etc) Thank you for pointing o

Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

2020-07-20 Thread David Blaikie via cfe-commits
Should the warning be disabled for LLVM overall, rather than only for this subproject? (& be good tohave some details in the commit at least of why this warning is being disabled - how it is noisy/unhelpful/etc) On Sun, Jul 19, 2020 at 8:20 AM Aaron Ballman via cfe-commits wrote: > > > Author: Aa

[clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

2020-07-19 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-07-19T11:19:48-04:00 New Revision: 97914164f8454e745219566d58479b5762cccd51 URL: https://github.com/llvm/llvm-project/commit/97914164f8454e745219566d58479b5762cccd51 DIFF: https://github.com/llvm/llvm-project/commit/97914164f8454e745219566d58479b5762cccd51.diff