https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/69011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/69011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6143,6 +6144,13 @@ static FunctionProtoTypeLoc GetPrototypeLoc(Expr *Fn) {
}
}
+ if (const auto *ME = dyn_cast(Fn)) {
Qwinci wrote:
Done.
https://github.com/llvm/llvm-project/pull/69011
___
cfe-commits
https://github.com/Qwinci updated
https://github.com/llvm/llvm-project/pull/69011
>From a7e8d6cf9d8339ce49494b1889e3099d313b1b0f Mon Sep 17 00:00:00 2001
From: Qwinci <32550582+qwi...@users.noreply.github.com>
Date: Fri, 13 Oct 2023 19:38:19 +0300
Subject: [PATCH] clangd: Show argument names
https://github.com/HighCommander4 edited
https://github.com/llvm/llvm-project/pull/69011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6143,6 +6144,13 @@ static FunctionProtoTypeLoc GetPrototypeLoc(Expr *Fn) {
}
}
+ if (const auto *ME = dyn_cast(Fn)) {
HighCommander4 wrote:
nit: make this an `else if` (i.e. make it part of the chain just above), and
then the `!Target` condition
https://github.com/HighCommander4 requested changes to this pull request.
Thanks for the update! Looks good with a final nit.
https://github.com/llvm/llvm-project/pull/69011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -6133,7 +6133,17 @@ ProduceSignatureHelp(Sema ,
MutableArrayRef Candidates,
// so that we can recover argument names from it.
static FunctionProtoTypeLoc GetPrototypeLoc(Expr *Fn) {
TypeLoc Target;
- if (const auto *T = Fn->getType().getTypePtr()->getAs()) {
+
+ if
https://github.com/Qwinci updated
https://github.com/llvm/llvm-project/pull/69011
>From e7380b096db802072d75d3bc48971d9758b704cf Mon Sep 17 00:00:00 2001
From: Qwinci <32550582+qwi...@users.noreply.github.com>
Date: Fri, 13 Oct 2023 19:38:19 +0300
Subject: [PATCH] clangd: Show argument names
https://github.com/HighCommander4 edited
https://github.com/llvm/llvm-project/pull/69011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
10 matches
Mail list logo
