Re: [clang-tools-extra] r250509 - Fix overlapping replacements in clang-tidy.

2015-10-19 Thread Angel Garcia via cfe-commits
Using these as the default comparison operators might not make much sense, as they don't take into account all the fields (they only look at ClangTidyError::Message). But here I just wanted to mimic existing behavior, so honestly I don't know. I implemented equality with !<&&!< to improve maintain

Re: [clang-tools-extra] r250509 - Fix overlapping replacements in clang-tidy.

2015-10-16 Thread David Blaikie via cfe-commits
On Fri, Oct 16, 2015 at 4:43 AM, Angel Garcia Gomez via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: angelgarcia > Date: Fri Oct 16 06:43:49 2015 > New Revision: 250509 > > URL: http://llvm.org/viewvc/llvm-project?rev=250509&view=rev > Log: > Fix overlapping replacements in clang-tid

[clang-tools-extra] r250509 - Fix overlapping replacements in clang-tidy.

2015-10-16 Thread Angel Garcia Gomez via cfe-commits
Author: angelgarcia Date: Fri Oct 16 06:43:49 2015 New Revision: 250509 URL: http://llvm.org/viewvc/llvm-project?rev=250509&view=rev Log: Fix overlapping replacements in clang-tidy. Summary: Prevent clang-tidy from applying fixes to errors that overlap with other errors' fixes, with one exceptio