Author: sepavloff
Date: Wed May 24 05:50:56 2017
New Revision: 303735
URL: http://llvm.org/viewvc/llvm-project?rev=303735&view=rev
Log:
Modify test so that it looks for patterns in stderr as well
With the change https://reviews.llvm.org/D33013 driver will not build
compilation object if command l
Done in r307661.
On Mon, Jul 10, 2017 at 2:08 PM, Alexander Kornienko
wrote:
> Benjamin has actually fixed the issue by reverting to the old behavior in
> r306822.
> I'll add a test for this behavior anyway.
>
> On Mon, Jul 10, 2017 at 11:47 AM, Alexander Kornienko
> wrote:
>
>> Sorry, missed
Thanks all!
On Wed, Jul 12, 2017 at 7:46 AM Alexander Kornienko
wrote:
> Done in r307661.
>
> On Mon, Jul 10, 2017 at 2:08 PM, Alexander Kornienko
> wrote:
>
>> Benjamin has actually fixed the issue by reverting to the old behavior in
>> r306822.
>> I'll add a test for this behavior anyway.
>>
I've been seeing errors from this test recently:
Command Output (stderr):
--
1 error generated.
Error while processing
/usr/local/google/home/blaikie/dev/llvm/src/tools/clang/tools/extra/test/clang-tidy/diagnostic.cpp.nonexistent.cpp.
/usr/local/google/home/blaikie/dev/llvm/src/tools/clang/tools/e
I cannot reproduce such fail, so I can only guess how changes made in
https://reviews.llvm.org/rL303756 and https://reviews.llvm.org/rL303741
could cause such problem. Behavior of `Driver::BuildCompilation` is changed
so that it returns null pointer if errors occur during driver argument
parse. It
Ah, I find that the test passes if I remove the compile_commands.json file
from my build directory (I have Ninja configured to generate a
compile_commands.json file).
Looks like what happens is it finds the compilation database and fails hard
when the database doesn't contain a compile command for
2017-06-14 4:24 GMT+07:00 David Blaikie :
> Ah, I find that the test passes if I remove the compile_commands.json file
> from my build directory (I have Ninja configured to generate a
> compile_commands.json file).
>
> Looks like what happens is it finds the compilation database and fails
> hard w
On Wed, Jun 14, 2017, 8:17 AM Serge Pavlov wrote:
> 2017-06-14 4:24 GMT+07:00 David Blaikie :
>
>> Ah, I find that the test passes if I remove the compile_commands.json
>> file from my build directory (I have Ninja configured to generate a
>> compile_commands.json file).
>>
>> Looks like what hap
2017-06-15 2:43 GMT+07:00 David Blaikie :
>
>
> On Wed, Jun 14, 2017, 8:17 AM Serge Pavlov wrote:
>
>> 2017-06-14 4:24 GMT+07:00 David Blaikie :
>>
>>> Ah, I find that the test passes if I remove the compile_commands.json
>>> file from my build directory (I have Ninja configured to generate a
>>>
https://sarcasm.github.io/notes/dev/compilation-database.html#cmake
If you enable the CMAKE_EXPORT_COMPILE_COMMANDS option in cmake (& have a
sufficiently recent cmake), then CMake will generate a
compile_commands.json in the root of the build tree. The test finds this &
fails, instead of finding
Ping (+Manuel, perhaps he's got some ideas about this, given background in
the tooling & compilation database work, or could point this to someone who
does?)
On Thu, Jun 15, 2017 at 10:40 AM David Blaikie wrote:
> https://sarcasm.github.io/notes/dev/compilation-database.html#cmake
>
> If you ena
With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is
created in the directory
/tools/clang/tools/extra/test/clang-tidy/Output, but the tests
from /llvm/tools/clang/tools/extra/test/clang-tidy run in the
directory /tools/clang/tools/extra/test/clang-tidy, which does
not contain json
On Sat, Jun 24, 2017 at 10:08 AM Serge Pavlov wrote:
> With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is
> created in the directory
> /tools/clang/tools/extra/test/clang-tidy/Output, but the tests
> from /llvm/tools/clang/tools/extra/test/clang-tidy run in the
> directory /tool
On Sat, Jun 24, 2017 at 10:08 AM Serge Pavlov wrote:
> With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is
> created in the directory
> /tools/clang/tools/extra/test/clang-tidy/Output,
>
I'd be really surprised if this is the case - why would
cmake/ninja/makefiles put the compil
2017-06-25 0:52 GMT+07:00 David Blaikie :
>
>
> On Sat, Jun 24, 2017 at 10:08 AM Serge Pavlov wrote:
>
>> With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is
>> created in the directory
>> /tools/clang/tools/extra/test/clang-tidy/Output,
>>
>>
>
> I'd be really surprised if this
Ah, I see now then.
I have a symlink from the root of my source directory pointing to the
compile_commands.json in my build directory.
I have this so that the vim YouCompleteMe plugin (& any other clang tools)
can find it, as they usually should, for using tools with the llvm/clang
project...
So
2017-06-26 4:05 GMT+07:00 David Blaikie :
> Ah, I see now then.
>
> I have a symlink from the root of my source directory pointing to the
> compile_commands.json in my build directory.
>
> I have this so that the vim YouCompleteMe plugin (& any other clang tools)
> can find it, as they usually sho
On Mon, Jun 26, 2017 at 5:31 AM Serge Pavlov wrote:
> 2017-06-26 4:05 GMT+07:00 David Blaikie :
>
>> Ah, I see now then.
>>
>> I have a symlink from the root of my source directory pointing to the
>> compile_commands.json in my build directory.
>>
>> I have this so that the vim YouCompleteMe plug
Sorry, missed this thread somehow. So, the behavior itself seems incorrect.
Clang tools should not be trying to find a compilation database in case the
command line has a `--`, but the driver fails to parse it. It should be a
hard failure. We also need a reliable test for this behavior (with a
comp
Benjamin has actually fixed the issue by reverting to the old behavior
in r306822.
I'll add a test for this behavior anyway.
On Mon, Jul 10, 2017 at 11:47 AM, Alexander Kornienko
wrote:
> Sorry, missed this thread somehow. So, the behavior itself seems
> incorrect. Clang tools should not be tryi
20 matches
Mail list logo