Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-10 Thread Zinovy Nis via cfe-commits
OK) вт, 10 апр. 2018 г. в 18:44, Alexander Kornienko : > I totally get it, no worries. But if you have free cycles, it would be > nice to brush this code up again. > > > On Tue, Apr 10, 2018 at 5:32 PM Zinovy Nis wrote: > >> Looks you are right, but I

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-10 Thread Alexander Kornienko via cfe-commits
I totally get it, no worries. But if you have free cycles, it would be nice to brush this code up again. On Tue, Apr 10, 2018 at 5:32 PM Zinovy Nis wrote: > Looks you are right, but I was in hurry trying to fix build bot failures > ASAP. > > вт, 10 апр. 2018 г. в 18:28,

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-10 Thread Zinovy Nis via cfe-commits
Looks you are right, but I was in hurry trying to fix build bot failures ASAP. вт, 10 апр. 2018 г. в 18:28, Alexander Kornienko : > On Mon, Apr 9, 2018 at 8:09 PM Zinovy Nis wrote: > >> I had compilation errors here on MVSV@PSP and for ARM: >> >>

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-10 Thread Alexander Kornienko via cfe-commits
On Mon, Apr 9, 2018 at 8:09 PM Zinovy Nis wrote: > I had compilation errors here on MVSV@PSP and for ARM: > > > > FAILED: /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-09 Thread Zinovy Nis via cfe-commits
I had compilation errors here on MVSV@PSP and for ARM: FAILED: /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/extra/clang-tidy/bugprone

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-09 Thread Alexander Kornienko via cfe-commits
On Fri, Apr 6, 2018 at 10:42 PM Zinovy Nis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: zinovy.nis > Date: Fri Apr 6 13:39:23 2018 > New Revision: 329452 > > URL: http://llvm.org/viewvc/llvm-project?rev=329452=rev > Log: > [clang-tidy] Fix compilation for

[clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-06 Thread Zinovy Nis via cfe-commits
Author: zinovy.nis Date: Fri Apr 6 13:39:23 2018 New Revision: 329452 URL: http://llvm.org/viewvc/llvm-project?rev=329452=rev Log: [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp Modified: