Re: [clang-tools-extra] r329550 - Fix unused variable warning.

2018-04-09 Thread Chandler Carruth via cfe-commits
I have no opinion other than removing the warning. =D This seemed to be the idiomatic pattern in the rest of LLVM and Clang. If someone wants to adjust this locally, by all means. On Mon, Apr 9, 2018 at 12:47 AM Zinovy Nis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thanks, Chandler. >

Re: [clang-tools-extra] r329550 - Fix unused variable warning.

2018-04-09 Thread Zinovy Nis via cfe-commits
Thanks, Chandler. assert(Result.Nodes.getNodeAs("call")); would also be fine. пн, 9 апр. 2018 г. в 10:29, Chandler Carruth via cfe-commits < cfe-commits@lists.llvm.org>: > Author: chandlerc > Date: Mon Apr 9 00:26:42 2018 > New Revision: 329550 > > URL: http://llvm.org/viewvc/llvm-project?r

[clang-tools-extra] r329550 - Fix unused variable warning.

2018-04-09 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Apr 9 00:26:42 2018 New Revision: 329550 URL: http://llvm.org/viewvc/llvm-project?rev=329550&view=rev Log: Fix unused variable warning. Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/b