Thanks for the explanation! I didn’t know that benchmark’s Initialize does
that, that was probably the source of my confusion. The suggestion looks
reasonable, I should try this approach, it looks to be cleaner.
-Kirill
> On 18 Sep 2018, at 21:16, Roman Lebedev wrote:
>
> On Tue, Sep 18, 2018
On Tue, Sep 18, 2018 at 10:09 PM, Kirill Bobyrev
wrote:
> Hi Roman,
>
> Is there any benefit of doing so? Also, I’m not sure whether I understood you
> correctly. Consuming benchmark options *before* trimming would probably not
> be the desired behaviour since the first two arguments arguments a
Hi Roman,
Is there any benefit of doing so? Also, I’m not sure whether I understood you
correctly. Consuming benchmark options *before* trimming would probably not be
the desired behaviour since the first two arguments arguments are passed
directly to the tool driver.
I might have misunderstoo
On Fri, Sep 14, 2018 at 3:21 PM, Kirill Bobyrev via cfe-commits
wrote:
> Author: omtcyfz
> Date: Fri Sep 14 05:21:09 2018
> New Revision: 342227
>
> URL: http://llvm.org/viewvc/llvm-project?rev=342227&view=rev
> Log:
> [clangd] NFC: Fix IndexBenchmark CLI arguments handling
>
> Modified:
> cla
Author: omtcyfz
Date: Fri Sep 14 05:21:09 2018
New Revision: 342227
URL: http://llvm.org/viewvc/llvm-project?rev=342227&view=rev
Log:
[clangd] NFC: Fix IndexBenchmark CLI arguments handling
Modified:
clang-tools-extra/trunk/clangd/benchmarks/IndexBenchmark.cpp
Modified: clang-tools-extra/tru
