https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/72146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Radu2k updated
https://github.com/llvm/llvm-project/pull/72146
>From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001
From: Radu2k
Date: Mon, 13 Nov 2023 17:49:06 +
Subject: [PATCH 1/9] [Flang][Clang] Add support for frame pointers in Flang
---
https://github.com/tblah approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/72146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Radu2k updated
https://github.com/llvm/llvm-project/pull/72146
>From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001
From: Radu2k
Date: Mon, 13 Nov 2023 17:49:06 +
Subject: [PATCH 1/8] [Flang][Clang] Add support for frame pointers in Flang
---
@@ -49,6 +49,7 @@ class CodeGenOptionsBase {
class CodeGenOptions : public CodeGenOptionsBase {
public:
+
tblah wrote:
nit: unrelated change
https://github.com/llvm/llvm-project/pull/72146
___
cfe-commits mailing
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/72146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Radu2k updated
https://github.com/llvm/llvm-project/pull/72146
>From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001
From: Radu2k
Date: Mon, 13 Nov 2023 17:49:06 +
Subject: [PATCH 1/7] [Flang][Clang] Add support for frame pointers in Flang
---
@@ -49,6 +49,26 @@ class CodeGenOptionsBase {
class CodeGenOptions : public CodeGenOptionsBase {
public:
+ /// The type of frame pointer used
+ enum class FramePointerKind {
+None,// Omit all frame pointers.
+NonLeaf, // Keep non-leaf frame pointers.
+All,
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/72146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah requested changes to this pull request.
While I guess it isn't wrong, it feels weird do declare all of the storage on
the front end driver side, but never set them (the member of the
CodeGenOpttions class, the changes in Frontend/CodeGenOptions.h, adding it to
@@ -6752,10 +6754,7 @@ def new_struct_path_tbaa : Flag<["-"],
"new-struct-path-tbaa">,
def mdebug_pass : Separate<["-"], "mdebug-pass">,
HelpText<"Enable additional debug output">,
MarshallingInfoString>;
-def mframe_pointer_EQ : Joined<["-"], "mframe-pointer=">,
-
https://github.com/Radu2k updated
https://github.com/llvm/llvm-project/pull/72146
>From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001
From: Radu2k
Date: Mon, 13 Nov 2023 17:49:06 +
Subject: [PATCH 1/6] [Flang][Clang] Add support for frame pointers in Flang
---
@@ -960,7 +1099,7 @@ bool tools::addOpenMPRuntime(ArgStringList , const
ToolChain ,
CmdArgs.push_back("-Bdynamic");
if (RTKind == Driver::OMPRT_GOMP && GompNeedsRT)
- CmdArgs.push_back("-lrt");
+CmdArgs.push_back("-lrt");
banach-space wrote:
banach-space wrote:
> Could you add some tests? In e.g. "driver-help.f90" we merely test that a
> flag is visible.
I see that you added
[frame-pointer-codegen.f90](https://github.com/llvm/llvm-project/pull/72146/files#diff-76ca50365c8a0eb4797ce10b121021e7da52cc86523d806e1ade530a897de7e8),
14 matches
Mail list logo
