subject:"\[libc\] \[clang\-tools\-extra\] \[libcxx\] \[clang\] \[llvm\] \[flang\] \[compiler\-rt\] \[mlir\] Make SmallVectorImpl destructor protected \(PR #71439\)"

[libc] [clang-tools-extra] [libcxx] [clang] [llvm] [flang] [compiler-rt] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

2023-11-07 Thread Krzysztof Drewniak via cfe-commits

krzysz00 wrote: I don't know if I'll be able to get to the SerializeToHsaco fix today, but passing in `SmallVectorImpl&` would be my preferred solution ... Or really that should be `MemoryBuffer &` or some other such structure if feasible. https://github.com/llvm/llvm-project/pull/71439 _

[libc] [clang-tools-extra] [libcxx] [clang] [llvm] [flang] [compiler-rt] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

2023-11-07 Thread Andy Kaylor via cfe-commits

andykaylor wrote: I don't think this change is time-critical. I can wait a few days for the SerializeToHsaco fix, but if it's going to be more than a few days, I'd prefer to land this change with an interim fix in SerializeToHsaco. @krzysz00 what's your preference? https://github.com/llvm/llv