[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-24 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/95018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-12 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: > Yes, the article you link to is highly relevant. Without this PR we're > hitting the problem described in example #4. > > We can promote the issue to a build failure by choosing a custom command > which can't run concurrently with itself: > > ```cmake > cmake_minimum_requ

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-12 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/95018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-11 Thread Tim Creech via cfe-commits
https://github.com/tcreech-intel edited https://github.com/llvm/llvm-project/pull/95018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-11 Thread Tim Creech via cfe-commits
tcreech-intel wrote: Yes, the article you link to is highly relevant. Without this PR we're hitting the problem described in example #4. We can promote the issue to a build failure by choosing a custom command which can't run concurrently with itself: ```cmake cmake_minimum_required(VERSION 3.

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-11 Thread Tim Creech via cfe-commits
https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/95018 >From 3e85695cc62abf8fe0943421708b5db67750b4ea Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Mon, 10 Jun 2024 11:07:55 -0400 Subject: [PATCH 1/2] [libclc] Improve dependencies to avoid build errors With

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-11 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: Hmm, isn't CMake fun? Thanks for looking into this. Unfortunately the file-level dependencies are there for a reason. With this patch, if I `rm builtins.link.nvptx64--.bc` and build `builtins.opt.nvptx64--` (with `ninja`), it builds the `link` target but doesn't actually reb

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-10 Thread Tim Creech via cfe-commits
https://github.com/tcreech-intel edited https://github.com/llvm/llvm-project/pull/95018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits