[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

2024-03-18 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: > > FWIW I don't think the build bots are actually building `libclc`. > > Locally, at least, it's not sufficient to specify > > `LLVM_ENABLE_PROJECTS=libclc` - you _also_ need > > `LLVM_EXTERNAL_PROJECTS=libclc`. Even then, it doesn't build for me > > in-tree, because it

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

2024-03-18 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/85634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

2024-03-18 Thread Tom Stellard via cfe-commits
tstellar wrote: > FWIW I don't think the build bots are actually building `libclc`. > > Locally, at least, it's not sufficient to specify > `LLVM_ENABLE_PROJECTS=libclc` - you _also_ need > `LLVM_EXTERNAL_PROJECTS=libclc`. Even then, it doesn't build for me in-tree, > because it assumes

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

2024-03-18 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. https://github.com/llvm/llvm-project/pull/85634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

2024-03-18 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: FWIW I don't think the build bots are actually building `libclc`. Locally, at least, it's not sufficient to specify `LLVM_ENABLE_PROJECTS=libclc` - you _also_ need `LLVM_EXTERNAL_PROJECTS=libclc`. Even then, it doesn't build for me in-tree, because it assumes

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

2024-03-18 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: @tstellar are you the code owner for `libclc`? https://github.com/llvm/llvm-project/pull/85634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

2024-03-18 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/85634 Having a mix of tabs and spaces makes the diff of any changes to the build system noisier than necessary. This commit unifies them to two spaces. This includes some minor cosmetic changes such as with