[libclc] [libclc] Stop installing CLC headers (PR #126908)

llvmbot wrote: /pull-request llvm/llvm-project#130017 https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Stop installing CLC headers (PR #126908)

frasercrmck wrote: /cherry-pick a2b05761724e5243056988d9d6bf1a5a94715b74 https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Stop installing CLC headers (PR #126908)

https://github.com/frasercrmck milestoned https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Stop installing CLC headers (PR #126908)

https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Stop installing CLC headers (PR #126908)

https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Stop installing CLC headers (PR #126908)

nikic wrote: This should be okay from the mesa side now. https://github.com/search?q=%22include+clc%2Fclc.h%22&type=code has some other mentions of clc/clc.h includes, but from a cursory looks all of those look very old. https://github.com/llvm/llvm-project/pull/126908 ___

[libclc] [libclc] Stop installing CLC headers (PR #126908)

frasercrmck wrote: It looks that with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33805 mesa is no longer using the libclc headers. https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] [libclc] Stop installing CLC headers (PR #126908)

https://github.com/arsenm commented: I'm fine removing the install, but I don't know how mesa is using this these days. The clang builtin header issues seem like a separate problem https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mail

[libclc] [libclc] Stop installing CLC headers (PR #126908)

frasercrmck wrote: ping. Are the discussions above blocking the PR? If clang's internal headers are unsuitable must we fix those before landing this, or temporarily fix the installation of libclc's headers instead? https://github.com/llvm/llvm-project/pull/126908 __

[libclc] [libclc] Stop installing CLC headers (PR #126908)

arsenm wrote: I suppose we could interpret the environment part of the triple to influence the target's reported set of extensions (plus consolidate all of these defines into the compiler). Do we even get consistent behavior when using -fdeclare-opencl-bulitins? I could believe we could just d

[libclc] [libclc] Stop installing CLC headers (PR #126908)

karolherbst wrote: > > Maybe there is a better tripple to be used in this case? However we do want > > to compile to SPIR-V (with the native target in the future anyway), it's > > just it enables a bunch of things automatically. > > I'm not sure I understand what the issue is. The defines here

[libclc] [libclc] Stop installing CLC headers (PR #126908)

arsenm wrote: > > Maybe there is a better tripple to be used in this case? However we do want > to compile to SPIR-V (with the native target in the future anyway), it's just > it enables a bunch of things automatically. I'm not sure I understand what the issue is. The defines here just declar

[libclc] [libclc] Stop installing CLC headers (PR #126908)

karolherbst wrote: Forgot to drop a link to the lines in question: https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/opencl-c-base.h#L16 https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llv

[libclc] [libclc] Stop installing CLC headers (PR #126908)

karolherbst wrote: The base header enables a bunch of extensions when `__SPIRV__` or `__SPIR__` is found, and that define is set automatically when a SPIRV or SPIR tripple is used. Maybe there is a better tripple to be used in this case? However we do want to compile to SPIR-V (with the nativ

[libclc] [libclc] Stop installing CLC headers (PR #126908)

arsenm wrote: I'm surprised any of the extension macros are defined in the builtin header, and they probably should not be there. The target info in clang records the extensions from the target, and I'd expect the predefined macros to be populated from there https://github.com/llvm/llvm-proj

[libclc] [libclc] Stop installing CLC headers (PR #126908)

frasercrmck wrote: CC @KarolHerbst. https://github.com/llvm/llvm-project/pull/126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Stop installing CLC headers (PR #126908)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/126908 The libclc headers are an implementation detail and are not intended to be used by others as OpenCL headers. The only artifacts of libclc we want to publish are the LLVM bytecode libraries. As the headers