[libclc] [libclc] Track dependencies through dependency files (PR #86965)

2024-03-28 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/86965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Track dependencies through dependency files (PR #86965)

2024-03-28 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: > The build here seems to be trying to define clc as a language, which then > results in needing to rely on language support magic like this. I think it > would be better if this did what rocm-device-libs does and treat these as > custom targets. I don't think it's

[libclc] [libclc] Track dependencies through dependency files (PR #86965)

2024-03-28 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. In the context of what the build is already doing, this should be fine https://github.com/llvm/llvm-project/pull/86965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] [libclc] Track dependencies through dependency files (PR #86965)

2024-03-28 Thread Matt Arsenault via cfe-commits
arsenm wrote: The build here seems to be trying to define clc as a language, which then results in needing to rely on language support magic like this. I think it would be better if this did what rocm-device-libs does and treat these as custom targets. I don't think it's particularly helpful

[libclc] [libclc] Track dependencies through dependency files (PR #86965)

2024-03-28 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/86965 This commit fixes the problem of missing build dependencies between libclc source files and their various includes (namely headers and .inc files). We would like to do this with compiler-generated