Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-20 Thread Duncan P. N. Exon Smith via cfe-commits
Reviewer's choice: http://reviews.llvm.org/D16360 (I've barely used phab, so let me know if it's broken somehow...) > On 2016-Jan-19, at 16:15, Eric Fiselier wrote: > > Hey Duncan, > > I know this isn't required, but would it be possible to put this on > phabricator? > > /Eric > > On Mon,

Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-19 Thread Eric Fiselier via cfe-commits
Hey Duncan, I know this isn't required, but would it be possible to put this on phabricator? /Eric On Mon, Jan 18, 2016 at 4:34 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > ping > > > On 2016-Jan-11, at 16:23, Duncan P. N. Exon Smith > wrote: > > > > ping > > > >> On 2016-Jan-0

Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-18 Thread Duncan P. N. Exon Smith via cfe-commits
ping > On 2016-Jan-11, at 16:23, Duncan P. N. Exon Smith > wrote: > > ping > >> On 2016-Jan-04, at 12:37, Duncan P. N. Exon Smith >> wrote: >> >> ping >> >>> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith >>> wrote: >>> >>> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith >>

Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-11 Thread Duncan P. N. Exon Smith via cfe-commits
ping > On 2016-Jan-04, at 12:37, Duncan P. N. Exon Smith > wrote: > > ping > >> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith >>> wrote: >>> >>> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert

Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-01-04 Thread Duncan P. N. Exon Smith via cfe-commits
ping > On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith > wrote: > > >> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith >> wrote: >> >> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert >> calls operator new when no insert occurs". That fix didn't apply to >> `unorder

Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

2015-12-17 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith > wrote: > > This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert > calls operator new when no insert occurs". That fix didn't apply to > `unordered_map` because unordered_map::value_type gets packed inside: > -- > union __val

[libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

2015-12-16 Thread Duncan P. N. Exon Smith via cfe-commits
This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert calls operator new when no insert occurs". That fix didn't apply to `unordered_map` because unordered_map::value_type gets packed inside: -- union __value_type { pair __nc; // Only C++11 or higher. pair __cc; // Always.