Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

2015-10-15 Thread Evgenii Stepanov via cfe-commits
Thanks! On Thu, Oct 15, 2015 at 1:30 PM, Eric Fiselier wrote: >> It would probably make sense for libc++ to remove -Wno-pedantic before >> removing -pedantic. > > Good localized fix. Committed as r250452. `remove_flags` hack needs to die > soon :( > > On Thu, Oct 15, 2015 at 2:00 PM, Evgenii Step

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

2015-10-15 Thread Eric Fiselier via cfe-commits
> It would probably make sense for libc++ to remove -Wno-pedantic before removing -pedantic. Good localized fix. Committed as r250452. `remove_flags` hack needs to die soon :( On Thu, Oct 15, 2015 at 2:00 PM, Evgenii Stepanov wrote: > It looks like, since libc++ removes -pedantic, we don't need

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

2015-10-15 Thread Evgenii Stepanov via cfe-commits
Transforms it to -Wno. On Thu, Oct 15, 2015 at 12:56 PM, Eric Fiselier wrote: > Removes it because "-Wno-pedantic" incorrectly matches -pedantic? If my > guess is correct, whoops :-( > > On Thu, Oct 15, 2015 at 1:51 PM, Evgenii Stepanov > wrote: >> >> Guess what this does to the -Wno-pedantic fl

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

2015-10-15 Thread Evgenii Stepanov via cfe-commits
It looks like, since libc++ removes -pedantic, we don't need to add -Wno-pedantic, so I can just fix it in MSan. It would probably make sense for libc++ to remove -Wno-pedantic before removing -pedantic. On Thu, Oct 15, 2015 at 12:57 PM, Evgenii Stepanov wrote: > Transforms it to -Wno. > > On Thu

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

2015-10-15 Thread Eric Fiselier via cfe-commits
Removes it because "-Wno-pedantic" incorrectly matches -pedantic? If my guess is correct, whoops :-( On Thu, Oct 15, 2015 at 1:51 PM, Evgenii Stepanov wrote: > Guess what this does to the -Wno-pedantic flag added by MSan? :) > > On Tue, Oct 13, 2015 at 4:56 PM, Eric Fiselier via cfe-commits > w

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

2015-10-15 Thread Evgenii Stepanov via cfe-commits
Guess what this does to the -Wno-pedantic flag added by MSan? :) On Tue, Oct 13, 2015 at 4:56 PM, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Tue Oct 13 18:56:33 2015 > New Revision: 250256 > > URL: http://llvm.org/viewvc/llvm-project?rev=250256&view=rev > Log: > Workaround -ped

[libcxx] r250256 - Workaround -pedantic flag added by LLVM

2015-10-13 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Oct 13 18:56:33 2015 New Revision: 250256 URL: http://llvm.org/viewvc/llvm-project?rev=250256&view=rev Log: Workaround -pedantic flag added by LLVM Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/l