Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

gt; >> >> >> From: Eric Fiselier <e...@efcs.ca> >> >> Date: Thursday, August 17, 2017 at 4:02 PM >> >> To: Petr Hosek <pho...@chromium.org> >> >> Cc: cfe-commits <cfe-commits@lists.llvm.org>, Marshall Clow >>

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

gt;> Cc: cfe-commits <cfe-commits@lists.llvm.org>, Marshall Clow > >> <mclow.li...@gmail.com>, Hans Wennborg <h...@chromium.org>, Shoaib > Meenai > >> <smee...@fb.com> > >> Subject: Re: [libcxx] r309474 - [libc++] Hoist extern template above

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

gt; >> Date: Thursday, August 17, 2017 at 4:02 PM >> To: Petr Hosek <pho...@chromium.org> >> Cc: cfe-commits <cfe-commits@lists.llvm.org>, Marshall Clow >> <mclow.li...@gmail.com>, Hans Wennborg <h...@chromium.org>, Shoaib Meenai >> <smee...@

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

@chromium.org>, Shoaib Meenai < > smee...@fb.com> > *Subject: *Re: [libcxx] r309474 - [libc++] Hoist extern template above > first use > > > > probably shouldn't merge this then. > > > > On Aug 17, 2017 4:54 PM, "Petr Hosek via cfe-commits&

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

om>, Hans Wennborg <h...@chromium.org>, Shoaib Meenai <smee...@fb.com> Subject: Re: [libcxx] r309474 - [libc++] Hoist extern template above first use probably shouldn't merge this then. On Aug 17, 2017 4:54 PM, "Petr Hosek via cfe-commits" <cfe-commits@lists.llvm.org<m

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

probably shouldn't merge this then. On Aug 17, 2017 4:54 PM, "Petr Hosek via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > This broke our build of WebKit with the following build failure: > > ../../buildtools/linux-x64/clang/bin/clang++ -MD -MF >

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

omium.org>, Shoaib Meenai <smee...@fb.com> Cc: Marshall Clow <mclow.li...@gmail.com>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> Subject: Re: [libcxx] r309474 - [libc++] Hoist extern template above first use Actually nevermind, it seems like it was a di

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Actually nevermind, it seems like it was a different change and this one is harmless (I'm still bisecting libc++ to find out which is causing the error below). On Thu, Aug 17, 2017 at 3:54 PM Petr Hosek wrote: > This broke our build of WebKit with the following build

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

This broke our build of WebKit with the following build failure: ../../buildtools/linux-x64/clang/bin/clang++ -MD -MF obj/apps/web_view/web_view_test.test_webview.o.d -DTOOLCHAIN_VERSION=4e89c701396412a50a901115ab4a2a09145f3777 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DCAIRO_HAS_FC_FONT=0

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Marshall: ping? On Thu, Aug 3, 2017 at 10:20 AM, Hans Wennborg wrote: > Sounds good to me, but Eric or Marshall need to sign off. > > On Thu, Aug 3, 2017 at 10:15 AM, Shoaib Meenai wrote: >> Ping. >> >> On 7/28/17, 7:57 PM, "Shoaib Meenai"

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Sounds good to me, but Eric or Marshall need to sign off. On Thu, Aug 3, 2017 at 10:15 AM, Shoaib Meenai wrote: > Ping. > > On 7/28/17, 7:57 PM, "Shoaib Meenai" wrote: > > Marshall, Eric, Hans, > > Any objections to backporting this to 5.0? It fixes a

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Ping. On 7/28/17, 7:57 PM, "Shoaib Meenai" wrote: Marshall, Eric, Hans, Any objections to backporting this to 5.0? It fixes a potential visibility issue for clients of the header. On 7/28/17, 7:54 PM, "cfe-commits on behalf of Shoaib Meenai via

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Marshall, Eric, Hans, Any objections to backporting this to 5.0? It fixes a potential visibility issue for clients of the header. On 7/28/17, 7:54 PM, "cfe-commits on behalf of Shoaib Meenai via cfe-commits" wrote:

[libcxx] r309474 - [libc++] Hoist extern template above first use

Author: smeenai Date: Fri Jul 28 19:54:41 2017 New Revision: 309474 URL: http://llvm.org/viewvc/llvm-project?rev=309474=rev Log: [libc++] Hoist extern template above first use This function template is referenced inside class basic_string as a friend function. The extern template declaration