Re: [libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-17 Thread Maxim Kuvyrkov via cfe-commits
Hi Eric, This seems to have broken ARM and AArch64 buildbots: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux/builds/850 http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux-noexceptions/builds/931

Re: [libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-17 Thread Bruno Cardoso Lopes via cfe-commits
Hi Eric, This is also failing http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/39697/ Can you take a look? Thanks, On Tue, Oct 17, 2017 at 9:07 AM, Eric Fiselier via cfe-commits wrote: > These shadowing warnings should be fixed now. > > /Eric > > On

Re: [libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-17 Thread Eric Fiselier via cfe-commits
These shadowing warnings should be fixed now. /Eric On Tue, Oct 17, 2017 at 10:03 AM, Maxim Kuvyrkov wrote: > Hi Eric, > > This seems to have broken ARM and AArch64 buildbots: > > http://lab.llvm.org:8011/builders/libcxx-libcxxabi- > libunwind-arm-linux/builds/850 >

[libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Oct 17 06:03:17 2017 New Revision: 315994 URL: http://llvm.org/viewvc/llvm-project?rev=315994=rev Log: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back. Summary: The constructors `vector(Iter, Iter, Alloc =