Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-26 Thread Don Hinton via cfe-commits
side llvm-config, so if you find llvm-config, you find these modules. >>> >>> So, unless I'm missing something, it looks like AddLLVM.cmake is always >>> available. >>> >>> >>>> >>>> On Jan 25, 2018, at 11:02, Shoaib Meenai <

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Duncan P. N. Exon Smith via cfe-commits
t; >>>> So, unless I'm missing something, it looks like AddLLVM.cmake is always >>>> available. >>>> >>>> >>>>> On Jan 25, 2018, at 11:02, Shoaib Meenai <smee...@fb.com >>>>> <mailto:smee...@fb.com>> wrote

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Don Hinton via cfe-commits
nai <smee...@fb.com> wrote: >>> >>> This is going to break building libc++ standalone (i.e. without any LLVM >>> repository or even its CMake modules), right? Some upstream users care a >>> lot about that use case (CC beanz and Duncan). >>> >>>

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Duncan P. N. Exon Smith via cfe-commits
care a >>>> lot about that use case (CC beanz and Duncan). >>>> >>>> From: cfe-commits <cfe-commits-boun...@lists.llvm.org >>>> <mailto:cfe-commits-boun...@lists.llvm.org>> on behalf of Don Hinton via >>>> cfe-commits <

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Duncan P. N. Exon Smith via cfe-commits
gt;> lot about that use case (CC beanz and Duncan). >>> >>> From: cfe-commits <cfe-commits-boun...@lists.llvm.org >>> <mailto:cfe-commits-boun...@lists.llvm.org>> on behalf of Don Hinton via >>> cfe-commits <cfe-commits@lists.llvm.org <mailto:cfe-

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Chris Bieneman via cfe-commits
gt; >>> From: cfe-commits <cfe-commits-boun...@lists.llvm.org >>> <mailto:cfe-commits-boun...@lists.llvm.org>> on behalf of Don Hinton via >>> cfe-commits <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> >>> Reply-To: D

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Don Hinton via cfe-commits
gt; on behalf of >> Don Hinton via cfe-commits <cfe-commits@lists.llvm.org> >> *Reply-To: *Don Hinton <hinto...@gmail.com> >> *Date: *Thursday, January 25, 2018 at 10:15 AM >> *To: *"cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> >> *Subje

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Chris Bieneman via cfe-commits
;> >> Date: Thursday, January 25, 2018 at 10:15 AM >> To: "cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>" >> <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> >> Subject: [libcxx] r323453 - [cmake] [libcxx]

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Don Hinton via cfe-commits
ton <hinto...@gmail.com> > *Date: *Thursday, January 25, 2018 at 10:15 AM > *To: *"cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> > *Subject: *[libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() > when adding shared libraries. >

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Duncan P. N. Exon Smith via cfe-commits
t 10:15 AM > To: "cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>" > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> > Subject: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when > adding shared libraries. &g

[libcxx] r323459 - Revert [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Don Hinton via cfe-commits
Author: dhinton Date: Thu Jan 25 11:22:23 2018 New Revision: 323459 URL: http://llvm.org/viewvc/llvm-project?rev=323459=rev Log: Revert [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. Shoaib Meenai pointed out this will break standalone builds when

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Shoaib Meenai via cfe-commits
s <cfe-commits@lists.llvm.org> Reply-To: Don Hinton <hinto...@gmail.com> Date: Thursday, January 25, 2018 at 10:15 AM To: "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> Subject: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared lib

[libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

2018-01-25 Thread Don Hinton via cfe-commits
Author: dhinton Date: Thu Jan 25 10:13:26 2018 New Revision: 323453 URL: http://llvm.org/viewvc/llvm-project?rev=323453=rev Log: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath usage