vvereschaka wrote:
[executorfix.diff.txt](https://github.com/llvm/llvm-project/files/12745676/executorfix.diff.txt)
@arichardson ,
here is few updates for your fix (please see attached file):
* added an escaping of quotes for the serialized lit parameter. There could be
an executor string some
arichardson wrote:
> @arichardson
>
> here is a problem with your changes when building the libraries on the
> windows cross toolchain builders
>
> * https://lab.llvm.org/buildbot/#/builders/60/builds/14086
> * https://lab.llvm.org/buildbot/#/builders/119/builds/15283
>
> https://lab.llvm.org
vvereschaka wrote:
@arichardson
here is a problem with your changes when building the libraries on the windows
cross toolchain builders
* https://lab.llvm.org/buildbot/#/builders/60/builds/14086
* https://lab.llvm.org/buildbot/#/builders/119/builds/15283
https://lab.llvm.org/buildbot/#/builde
@@ -314,5 +317,14 @@ def getStdFlag(cfg, std):
AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
],
),
+Parameter(
+name="executor",
+type=str,
+default=f"{sys.executable}
{Path(__file__).resolve().parent.parent.parent
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/66545
>From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Mon, 25 Sep 2023 08:22:27 -0700
Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Allow overriding the
ex
@@ -134,3 +134,8 @@ ABI Affecting Changes
Build System Changes
+
+- The ``LIBCXX_EXECUTOR`` CMake variable has been deprecated. If you are
relying on this, the new replacement
+ is either passing ``-Dexecutor=...`` to `llvm-lit`` or to make it persistent
@@ -330,5 +330,14 @@ def getModuleFlag(cfg, enable_modules):
AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
],
),
+Parameter(
arichardson wrote:
Done now, tested both the default and the case where LIBCXX_EXECUTOR is set.
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/66545
>From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Mon, 25 Sep 2023 08:22:27 -0700
Subject: [PATCH] [libunwind][libc++][libc++abi] Allow overriding the executo
10 matches
Mail list logo