Re: [libunwind] r297174 - Improve readability and correctness of the OS specific libunwind bits.

@Renato: What's your take on Ed's idea? We use phab for all sorts of reviews, but it should be possible to figure out which repository a review is intended to land on and add cfe-commits or llvm-commits appropriately. Although, for throw-away reviews, it might generate too much spam. Cheers, /

Re: [libunwind] r297174 - Improve readability and correctness of the OS specific libunwind bits.

Hi Asiri, 2017-03-07 20:42 GMT+01:00 Asiri Rathnayake : > Could you please always include cfe-commits as a subscriber in you phab > reviews? > > We would like to be aware of these changes in advance before they land. Sure thing! I'll try to do that from now on. That

Re: [libunwind] r297174 - Improve readability and correctness of the OS specific libunwind bits.

Hi Ed, Could you please always include cfe-commits as a subscriber in you phab reviews? We would like to be aware of these changes in advance before they land. Thanks. / Asiri On 7 Mar 2017 6:27 p.m., "Ed Schouten via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: ed > Date:

[libunwind] r297174 - Improve readability and correctness of the OS specific libunwind bits.

Author: ed Date: Tue Mar 7 12:15:52 2017 New Revision: 297174 URL: http://llvm.org/viewvc/llvm-project?rev=297174=rev Log: Improve readability and correctness of the OS specific libunwind bits. All of the access to __exidx_*, dl_iterate_phdr(), etc. is specific to the findUnwindSections()