[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

joker-eph wrote: Sorry, had to revert because this broke a buildbot: ``` llvm/lib/Support/RISCVISAInfo.cpp:910:18: error: call to deleted constructor of 'llvm::Error' return E; ^ ``` https://lab.llvm.org/buildbot/#/builders/61/builds/53704 https://github.com/llvm/llvm-project/pull/78120 __

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/78120 >From f3444e9f434a5084b16ad25981428549c5b2e151 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 14 Jan 2024 19:41:59 -0800 Subject: [PATCH 1/9] [RISCV] Relax march string order constraint --- clang/test/Driver/

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/78120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/78120 >From 8f7b429d2f7fe791a2a469e3d232d33abba1bef8 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 14 Jan 2024 19:41:59 -0800 Subject: [PATCH 1/9] [RISCV] Relax march string order constraint --- clang/test/Driver/

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/78120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/78120 >From 7ad5726d93e957050723a7df7a8384bc9ff694b3 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 14 Jan 2024 19:41:59 -0800 Subject: [PATCH 1/9] [RISCV] Relax march string order constraint --- clang/test/Driver/

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/78120 >From 7ad5726d93e957050723a7df7a8384bc9ff694b3 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 14 Jan 2024 19:41:59 -0800 Subject: [PATCH 1/8] [RISCV] Relax march string order constraint --- clang/test/Driver/

[clang-tools-extra] [llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

@@ -793,153 +887,69 @@ RISCVISAInfo::parseArchString(StringRef Arch, bool EnableExperimentalExtension, Minor = Version->Minor; } -ISAInfo->addExtension(StringRef(&Baseline, 1), {Major, Minor}); +// Postpone AddExtension until end of this function +SeenEx

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

@@ -695,6 +696,106 @@ RISCVISAInfo::parseNormalizedArchString(StringRef Arch) { return std::move(ISAInfo); } +static Error splitExtsByUnderscore(StringRef Exts, + std::vector &SplitExts) { + SmallVector Split; + if (Exts.empty()) +retu

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/78120 >From 88eef23588b545f29f3fe62a702ed2121b53c7cd Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 14 Jan 2024 19:41:59 -0800 Subject: [PATCH 1/7] [RISCV] Relax march string order constraint --- clang/test/Driver/

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

@@ -695,6 +696,106 @@ RISCVISAInfo::parseNormalizedArchString(StringRef Arch) { return std::move(ISAInfo); } +static Error splitExtsByUnderscore(StringRef Exts, + std::vector &SplitExts) { + SmallVector Split; + if (Exts.empty()) +retu

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

@@ -695,6 +695,106 @@ RISCVISAInfo::parseNormalizedArchString(StringRef Arch) { return std::move(ISAInfo); } +static Error splitExtsByUnderscore(StringRef Exts, + std::vector &SplitedExts) { topperc wrote: `SplitExts` Spli

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/BeMg edited https://github.com/llvm/llvm-project/pull/78120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/78120 >From 88eef23588b545f29f3fe62a702ed2121b53c7cd Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 14 Jan 2024 19:41:59 -0800 Subject: [PATCH 1/4] [RISCV] Relax march string order constraint --- clang/test/Driver/

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

@@ -785,153 +878,61 @@ RISCVISAInfo::parseArchString(StringRef Arch, bool EnableExperimentalExtension, Minor = Version->Minor; } -ISAInfo->addExtension(StringRef(&Baseline, 1), {Major, Minor}); +// Postpone AddExtension until end of this function +SeenEx

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

kito-cheng wrote: I am working on GCC part[1], and it's still under review, also @bemg is working very closely with me :) [1] https://gcc.gnu.org/pipermail/gcc-patches/2024-January/642151.html https://github.com/llvm/llvm-project/pull/78120 ___ cfe-c

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Piyou Chen (BeMg) Changes Address the https://github.com/riscv-non-isa/riscv-toolchain-conventions/pull/14 This patch relax the `-march` string for accept any order. 1. single-letter extension can be arbitrary order - march=rv

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

https://github.com/BeMg created https://github.com/llvm/llvm-project/pull/78120 Address the https://github.com/riscv-non-isa/riscv-toolchain-conventions/pull/14 This patch relax the `-march` string for accept any order. 1. single-letter extension can be arbitrary order - march=rv32iamdf 2