https://github.com/hahnjo approved this pull request.
Looks reasonable to me. I know this fixes a test error for MinGW, but if
possible maybe let it sit until early next week in case somebody else has a
different opinion on moving `host=` to `lit`.
https://github.com/llvm/llvm-project/pull/711
mstorsjo wrote:
Posting for a second review instead of just relanding the patch as is; in order
to check the host triple, I had to add the `host=triple` string; it was
previously only available for tests under `llvm/test`, but let's move it to the
common llvm test configuration just like the `
llvmbot wrote:
@llvm/pr-subscribers-platform-windows
Author: Martin Storsjö (mstorsjo)
Changes
The const.cpp testcase fails when running in MSVC mode, while it does succeed
in MinGW mode.
In MSVC mode, there are more constructor invocations than expected, as the
printout looks like this
