https://github.com/mtrofin approved this pull request.
Thanks for adding license info!
https://github.com/llvm/llvm-project/pull/72319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boomanaiden154 wrote:
I believe this is ready to go now. All the tests have been converted to
lit-style tests and everything has been wired up into a `check-mlgo-utils`
CMake target.
I talked with Mircea about the absl dependency. It's not in the tests anymore
and the plan is to refactor in a
mtrofin wrote:
> > Would it be also possible to remove the dependency on
> > [Abseil](https://github.com/abseil/abseil-py)? None of the existing scripts
> > in LLVM use it and I don't think we should be introducing this dependency.
> > It looks like Abseil is only used for flag parsing, loggin
@@ -0,0 +1,6 @@
+# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
mtrofin wrote:
Ack - thanks for clarifying the directory structure; looking around, there
doesn't seem to be much of a precedent either; so... how about
`llvm/utils
@@ -0,0 +1,6 @@
+# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
mtrofin wrote:
why do we need `mlgo/mlgo` - could we just do `mlgo/corpus` and
`mlgo/tests/corpus` - this leaves it open to add later non-corpus related
things if n
@@ -0,0 +1,12 @@
+# MLGO Python Library
+
+This folder contains the MLGO python library. This library consists of telling
mtrofin wrote:
I wouldn't call it "the" MLGO python library, rather it's utilities for MLGO.
Also please read the rest of the para (esp. fir
https://github.com/mtrofin commented:
I'm assuming the files were drop-in copied from google/ml-compiler-opt, so no
need to comment there; also that we would subsequently delete them from there
and depend on this package.
https://github.com/llvm/llvm-project/pull/72319
___
